Merge pull request #3859 from manyfold3d/delay-approval-mail-sending

Fix signup validation failure bug

Author: Floppy

app/controllers/users/registrations_controller.rb

@@ -28,10 +28,10 @@ def edit
   def create
     authorize User
     super do |user|
-      if SiteSettings.approve_signups
-        user.update(approved: false)
-        ModeratorMailer.with(user: @user).new_approval.deliver_later if SiteSettings.email_configured?
-      end
+      user.update(approved: false) if SiteSettings.approve_signups
+    end
+    if @user.persisted?
+      ModeratorMailer.with(user: @user).new_approval.deliver_later if SiteSettings.approve_signups && SiteSettings.email_configured?
     end
   end