If you provide a bad wkhtmltopdf option, you should get an exception

Rory McCann · Rory McCann · commit 5850063d87c3 · 2014-03-25T12:50:46.000Z
If you provide an invalid wkhtmltopdf option and wkhtmltopdf fails to
execute, you should be told about this straight away, by an exception
being raised.
diff --git a/pdfkit/pdfkit.py b/pdfkit/pdfkit.py
@@ -105,9 +105,14 @@ def to_pdf(self, path=None):
             input = None
         stdout, stderr = result.communicate(input=input)
 
+        exit_code = result.returncode
+
         if 'Error' in stderr.decode('utf-8'):
             raise IOError('wkhtmltopdf reported an error:\n' + stderr.decode('utf-8'))
 
+        if exit_code != 0:
+            raise IOError("wkhtmltopdf exited with non-zero code {0}. error:\n{1}".format(exit_code, stderr.decode("utf-8")))
+
         # Since wkhtmltopdf sends its output to stderr we will capture it
         # and properly send to stdout
         if '--quiet' not in args:
diff --git a/tests/pdfkit-tests.py b/tests/pdfkit-tests.py
@@ -293,5 +293,14 @@ def test_raise_error_with_wrong_css_path(self):
         with self.assertRaises(IOError):
             r.to_pdf()
 
+    def test_raise_error_if_bad_wkhtmltopdf_option(self):
+        r = pdfkit.PDFKit('<html><body>Hai!</body></html>', 'string',
+                          options={'bad-option': None})
+        with self.assertRaises(IOError) as cm:
+            r.to_pdf()
+
+        raised_exception = cm.exception
+        self.assertRegexpMatches(raised_exception.message, '^wkhtmltopdf exited with non-zero code 1. error:\nUnknown long argument --bad-option\n')
+
 if __name__ == "__main__":
     unittest.main()
