[use mirror from]: issue when DE is not in english

[scachemaille]

if the user use a different language display than english (tested with french) when the user change the Use mirrors from to "Worldwide" (in english as in french it's translated to Monde entier).
pamac don't comment the OnlyCountry= entry in pacman-mirrors.conf but put the translation of worldwide as country in the option.

pamac V4.1.1-1

[papajoker]

mirrors_config.vala#126
test if value is not in _countrys list then #comment, is not more robust ?

[guinux]

I can't reproduce it, for me it works as expected even in French. Does someone else can ?

[scachemaille]

A problem was reported in French forum and I tried to understand it and I could reproduce it. It's why I reported it.
My test was on plasma 5.7 I will check the DE of the original poster in the French forum, it seems he is on XFCE openrc on stable.

Just in case as I don't really understand all about display and regional settings.
my plasma settings in manjaro-settings-manager -> locale all is in english. but in regional settings of KDE all formats is in Swiss French and the preferred language is in American English, if I add French as 2nd preferred language. Pamac choose french (I noticed that some of GTK apps choose French and QT/KDE apps choose English I don't get why. ;) )

[scachemaille]

hmmm. it seems it's related to the fact that the root display language or system language is not the same as my KDE. I tried to change the display language to FR in manjaro-settings-manager and it works.

But. now if I set the preffered language to English in KDE settings (still with French in manjaro-settings-manager as display language) pamac save OnlyCountry=Worlwide and don't comment it

[scachemaille]

To have different language settings for root (system) and the user also affect the combobox after the config is written. it become blank.