Fix #98

Author: lol768

Storages/ManagedCode.Storage.FileSystem/FileSystemStorage.cs

@@ -92,7 +92,7 @@ protected override async Task<Result<BlobMetadata>> UploadInternalAsync(Stream s
 
         var filePath = GetPathFromOptions(options);
 
-        using (var fs = new FileStream(filePath, FileMode.OpenOrCreate, FileAccess.Write))
+        using (var fs = new FileStream(filePath, FileMode.Create, FileAccess.Write))
         {
             stream.Seek(0, SeekOrigin.Begin);
             await stream.CopyToAsync(fs, 81920, cancellationToken);
@@ -222,4 +222,4 @@ private void EnsureDirectoryExist(string directory)
         if (!Directory.Exists(path))
             Directory.CreateDirectory(path);
     }
-}
+}

Tests/ManagedCode.Storage.Tests/Storages/FileSystem/FileSystemUploadTests.cs

@@ -1,5 +1,11 @@
+using System;
+using System.IO;
+using System.Text;
+using System.Threading.Tasks;
+using FluentAssertions;
 using ManagedCode.Storage.Tests.Common;
 using Microsoft.Extensions.DependencyInjection;
+using Xunit;
 
 namespace ManagedCode.Storage.Tests.Storages.FileSystem;
 
@@ -14,4 +20,66 @@ protected override ServiceProvider ConfigureServices()
     {
         return FileSystemConfigurator.ConfigureServices("managed-code-blob");
     }
-}
+
+    [Fact]
+    public async Task UploadAsync_AsStream_CorrectlyOverwritesFiles()
+    {
+        // Arrange
+
+        var uploadStream1 = new MemoryStream(90*1024);
+        var buffer = new byte[90 * 1024];
+        var random = new Random();
+        random.NextBytes(buffer);
+        uploadStream1.Write(buffer, 0, buffer.Length);
+
+        var uploadStream2 = new MemoryStream(512);
+        var zeroByteBuffer = new byte[512];
+        uploadStream2.Write(zeroByteBuffer);
+        var filenameToUse = "UploadAsync_AsStream_CorrectlyOverwritesFiles.bin";
+
+        var temporaryDirectory = Path.GetTempPath();
+
+        // Act
+        var firstResult = await Storage.UploadAsync(uploadStream1, options =>
+        {
+            options.FileName = filenameToUse;
+            options.Directory = temporaryDirectory;
+        });
+
+        firstResult.IsSuccess.Should().BeTrue();
+
+        // let's download it
+        var downloadedResult = await Storage.DownloadAsync(options =>
+        {
+            options.FileName = filenameToUse;
+            options.Directory = temporaryDirectory;
+        });
+        downloadedResult.IsSuccess.Should().BeTrue();
+        // size
+        downloadedResult.Value!.FileInfo.Length.Should().Be(90*1024);
+
+
+        var secondResult = await Storage.UploadAsync(uploadStream2, options =>
+        {
+            options.FileName = filenameToUse;
+            options.Directory = temporaryDirectory;
+        });
+
+        secondResult.IsSuccess.Should().BeTrue();
+
+        // let's download it
+        downloadedResult = await Storage.DownloadAsync(options =>
+        {
+            options.FileName = filenameToUse;
+            options.Directory = temporaryDirectory;
+        });
+        downloadedResult.IsSuccess.Should().BeTrue();
+        // size
+        downloadedResult.Value!.FileInfo.Length.Should().Be(512);
+
+        // content
+        using var ms = new MemoryStream();
+        await downloadedResult.Value!.FileStream.CopyToAsync(ms);
+        ms.ToArray().Should().BeEquivalentTo(zeroByteBuffer);
+    }
+}