Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain global column types in returned dataframe when date_range or row_range filter out all rows #1146

Open
alexowens90 opened this issue Dec 11, 2023 · 0 comments

Comments

@alexowens90
Copy link
Collaborator

alexowens90 commented Dec 11, 2023

When a column in a returned dataframe has no values in it (e.g. if dynamic schema is enabled but this column was not present in the the date range requested) we return a column with dtype float64 full of NaNs in Pandas 1.X, and with dtype object filled with Nones in Pandas 2.X, matching Pandas behaviour for empty columns in both cases.

In the special case where there are no rows at all, we should maintain the dtype of the column as it is for that symbol-version pair in storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants