Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Add e2e test for auth/login #133

Merged
merged 10 commits into from
May 14, 2020
Merged

[tests] Add e2e test for auth/login #133

merged 10 commits into from
May 14, 2020

Conversation

yashmurty
Copy link
Member

Changes:

  • Add e2e test for auth/login - normal user login.
  • Add validation to prefecture payload during login.

@yashmurty yashmurty self-assigned this May 13, 2020
shogo-mitomo
shogo-mitomo approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@shogo-mitomo shogo-mitomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shogo-mitomo shogo-mitomo merged commit f43e8fc into master May 14, 2020
@shogo-mitomo shogo-mitomo deleted the yash/e2e-part2 branch May 14, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo-mitomo shogo-mitomo shogo-mitomo approved these changes

@DaisukeHirata DaisukeHirata Awaiting requested review from DaisukeHirata

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashmurty @shogo-mitomo