Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACL - PlantUML diagrams & Admin Delete #120

Merged
merged 11 commits into from
May 8, 2020
Merged

ACL - PlantUML diagrams & Admin Delete #120

merged 11 commits into from
May 8, 2020

Conversation

yashmurty
Copy link
Member

@yashmurty yashmurty commented May 7, 2020 •
edited
Loading

Changes:

  • Create ACL - PlantUML diagrams for easier understanding.
  • Add DELETE /admin/users feature. 🙇

Update:

  • Also added admin user delete feature in this PR. ✨

@yashmurty yashmurty added documentation Improvements or additions to documentation enhancement New feature or request 🙏 Please Review Me labels May 7, 2020
@yashmurty yashmurty self-assigned this May 7, 2020
@yashmurty yashmurty changed the title ACL - PlantUML diagrams ACL - PlantUML diagrams & Admin Delete May 7, 2020
@DaisukeHirata DaisukeHirata merged commit 44c2643 into master May 8, 2020
@DaisukeHirata DaisukeHirata deleted the yash/admin-acl-p2 branch May 8, 2020 02:09
@DaisukeHirata
Copy link
Contributor

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaisukeHirata DaisukeHirata Awaiting requested review from DaisukeHirata

@shogo-mitomo shogo-mitomo Awaiting requested review from shogo-mitomo

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yashmurty @DaisukeHirata @shogo-mitomo