Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] /auth/admin/login（POST） response with a status code of 201 is returned. #148

Closed
monstar-hashimoto-ryosuke opened this issue Apr 22, 2020 · 1 comment
Closed

[API] /auth/admin/login（POST） response with a status code of 201 is returned. #148

monstar-hashimoto-ryosuke opened this issue Apr 22, 2020 · 1 comment

Comments

@monstar-hashimoto-ryosuke
Copy link

Bug Details

  • The status code of the /auth/admin/login（POST） response is returned as 201 and the data is also returned.
    • By Swagger's definition, the status code is 204, with no response data.

covid-auth-admin-login

# Implementation environment * Postman（Mac）

Expected value

  • As defined in Swagger, the status code returns 204 as a response

Reproduction method

  1. Open an API test tool such as Postman and configure the following
  2. Enter the URL. https://api-dev.mamori-i.jp/auth/admin/login
  3. Obtain an access token from the authentication screen
  4. Set the access token obtained in 3 as the Bearer Token
  5. Send the API
@shogo-mitomo
Copy link
Member

The app team requested that to return an empty JSON instead of no response.
Therefore, the status code has been changed to 200. We have also changed the Swagger API definition document to do so.

@DaisukeHirata DaisukeHirata transferred this issue from another repository May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shogo-mitomo @monstar-hashimoto-ryosuke