Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd.exe shell doesn't work with micromamba 1 #237

Closed
pavelzw opened this issue Oct 7, 2024 · 7 comments
Closed

cmd.exe shell doesn't work with micromamba 1 #237

pavelzw opened this issue Oct 7, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@pavelzw
Copy link
Member

pavelzw commented Oct 7, 2024

#234 broke old micromamba versions, see #236

image

@pavelzw
Copy link
Member Author

pavelzw commented Oct 7, 2024

CC @JohanMabille @jjerphan

@pavelzw pavelzw added the bug Something isn't working label Oct 7, 2024
@pavelzw
Copy link
Member Author

pavelzw commented Oct 7, 2024

Also, could you introduce a comment in the code relevant code line referencing to #230 (comment) ?

Otherwise nobody will know why this change was made in a year from now

@pavelzw
Copy link
Member Author

pavelzw commented Oct 7, 2024

if you decide that you don't want to support micromamba 1 for setup-micromamba@v2, we should at least print out a meaningful error message that indicates this

@jjerphan
Copy link
Member

jjerphan commented Oct 7, 2024

I think that both major versions of micromamba and setup-micromamba must be tied, and that this should be documented.

@maresb
Copy link
Contributor

maresb commented Nov 25, 2024

I'm seeing this now with v2 here

@jjerphan
Copy link
Member

This should be fixed by #246.

@jjerphan
Copy link
Member

jjerphan commented Nov 25, 2024

Can an admin review and publish 2.0.2 on GitHub Marketplace? For instance, @pavelzw? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants