Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider usages of unsafe #18

Open
aochagavia opened this issue Jan 25, 2024 · 0 comments
Open

Reconsider usages of unsafe #18

aochagavia opened this issue Jan 25, 2024 · 0 comments

Comments

@aochagavia
Copy link
Contributor

Resolvo currently has 13 unsafe blocks. They are related to two things:

  • Getting stuff from a slice / vec without bound checks;
  • Implementing FrozenCopyMap.

Since this is a pretty foundational library, I think we should strive to either avoid using unsafe entirely or otherwise make sure to have the appropriate infrastructure to prevent errors (e.g. running tests under miri, fuzzing, etc).

@baszalmstra any thoughts on this? I assume the unsafe that has been introduced was due to performance optimizations. Did it provide a measurable improvement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant