Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Generate and install etc/profile.d/mamba.sh for mamba #3723

Merged

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Jan 3, 2025

Fix conda-forge/mamba-feedstock#282.

etc/profile.d/mamba.sh is currently shipped as part of mamba-package (the CMake target) itself shipped as part of libmamba (the conda package on conda-forge). If libmamba alone is installed (e.g. when conda is and mamba is not), then it fail because mamba (which is called by this script) is not available.

etc/profile.d/mamba.sh instead must be shipped by mamba only (not even micromamba).

See conda-forge/mamba-feedstock#283 for the integration tests.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan force-pushed the build/adapt-distribution-of-mamba.sh branch from d282ddc to 2adbb72 Compare January 3, 2025 11:27
@jjerphan jjerphan marked this pull request as ready for review January 3, 2025 15:43
micromamba/CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Klaim <Klaim@users.noreply.github.com>
@jjerphan
Copy link
Member Author

jjerphan commented Jan 6, 2025

Let me update conda-forge/mamba-feedstock#283.

@jjerphan
Copy link
Member Author

jjerphan commented Jan 6, 2025

Merging as conda-forge/mamba-feedstock#283 completed successfully as of conda-forge/mamba-feedstock@2045b78.

@jjerphan jjerphan merged commit d178696 into mamba-org:main Jan 6, 2025
34 checks passed
@jjerphan jjerphan deleted the build/adapt-distribution-of-mamba.sh branch January 6, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libmamba includes mamba.sh activation script, but mamba doesn't exist
2 participants