Skip to content

Commit a8dbee5

Browse files
authored
Merge pull request chriskuehl#7 from chriskuehl/dont-pin-puppet
Don't pin Puppet via gemspec, instead use additional_dependencies
2 parents 44bc886 + 7545ee2 commit a8dbee5

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

README.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,3 +60,16 @@ to the `puppet-validate` hook:
6060

6161
Any other arguments to `puppet-validate` will be fed directly to
6262
`puppet parser validate`, as long as they are in the format `--arg=value`.
63+
64+
By default, the latest versions of `puppet` and `puppet-lint` are used. If
65+
you'd like to use a different version, you can pass `additional_dependencies`
66+
when definining the hooks, e.g.:
67+
68+
```yaml
69+
hooks:
70+
- id: puppet-validate
71+
additional_dependencies: ['puppet:3.8.7']
72+
```
73+
74+
To see what dependencies you might want to change, take a look at
75+
`hooks.yaml` in this repo.

__fake_gem.gemspec

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ Gem::Specification.new do |s|
44
s.authors = 'Chris Kuehl'
55
s.summary = 'pre-commit hooks for Puppet projects'
66
s.description = 'pre-commit hooks for Puppet projects'
7-
s.add_dependency 'puppet-lint', '1.1.0'
8-
s.add_dependency 'puppet', '3.8.1'
97

108
s.bindir = 'ruby-stubs'
119
s.executables = ['puppet-validate', 'erb-validate', 'epp-validate']

hooks.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
entry: puppet-validate
55
language: ruby
66
files: \.pp$
7+
additional_dependencies: ['puppet']
78

89
- id: erb-validate
910
name: Validate ERB templates
@@ -18,10 +19,12 @@
1819
entry: epp-validate
1920
language: ruby
2021
files: \.epp$
22+
additional_dependencies: ['puppet']
2123

2224
- id: puppet-lint
2325
name: puppet-lint
2426
description: Check Puppet manifests for stylistic problems
2527
entry: puppet-lint
2628
language: ruby
2729
files: \.pp$
30+
additional_dependencies: ['puppet-lint']

0 commit comments

Comments
 (0)