Version 2: Adding languages to Bible Linker

[majal]

Adding languages to Bible Linker is good.

This requires suggestions in the way the code is made and how the Menu will be presented.

Please feel free to add your suggestions and help test proposed codes in this thread.

[majal]

The first code submission and discussion was for the Tagalog language. This was submitted by @JerwellSavella.

[majal]

The next was a request for the Spanish language by @SanSon97.

In response, @venjot created a refactor that included the Tagalog and Spanish languages.

We will appreciate testing of this new code in the different languages it supports (three for the moment) and any suggestions to improve it.

[majal]

Hi @venjot! Thanks for the code. This looks nice. There is just this little bug in the English language.

[majal]

@venjot, do you think we should add languages for the menu? The phrases "Link verses using..." and "Choose language and version" are in English. 🙂 Maybe later down the line?

[venjot]

Hi kuya @majal , I just fixed the duplicate New World Translation (NWL)(WOL).

Duplicate fix

Yes, i think adding languages for the menu is a good feature. :)

[SanSon97]

Dear brothers, thank you so much for your time and help.

Although I don't have programming knowledge, I have used Visual Studio Code to translate to Spanish parts of other christian apps. I will be more than happy to translate any parts for you.

I already have your code in VSC.

SanSon97

[majal]

Awesome. We'll surely ask for your help in Spanish translation. 🙂

While the language additions is in development, do you think you could help us test out the Spanish version from @venjot’s development code?

https://github.com/venjot/bible-linker-google-docs/tree/feature/add-bible-languages

[SanSon97]

Thank you so much @majal and @venjot for the opportunity to help. I have done a couple testings, it works great!!
Tried a long article and only got a few errors as seen in the video.

Bible.Linker.Test.mp4

One question. Is there a way to open the links in JW Library? The link in my iPad and Windows PC opens JW Library but then goes straight to wol.jw.org

[venjot]

Hi @SanSon97 , You might not using the latest code? the latest link for Spanish, We've changed it from "ES" to "S".

see our latest code change.

[venjot]

Hi @SanSon97 ,

Can you help me with this? We've noticed the bible verse below.

Berajot 9:5.

May I know what bible book is that in english?

We've found the following as missing abbreviation in spanish.

• Rev
• Isa

Thanks you :)
We really appreciate your help.

[SanSon97]

That's the name of of a Mishnah book :) The article is making reference to it.

Here's the English paragraph
*** it-2 p. 6 Jehovah ***
Yet, despite these negative views, one also finds in the first section of the Mishnah the positive injunction that “a man should salute his fellow with [the use of] the Name [of God],” the example of Boaz (Ru 2:4) then being cited.—Berakhot 9:5.

[SanSon97]

BTW it's my pleasure being able to help.

[venjot]

That's the name of of a Mishnah book :) The article is making reference to it.

Here's the English paragraph *** it-2 p. 6 Jehovah *** Yet, despite these negative views, one also finds in the first section of the Mishnah the positive injunction that “a man should salute his fellow with [the use of] the Name [of God],” the example of Boaz (Ru 2:4) then being cited.—Berakhot 9:5.

I see.

We've already added "Isa" as abbreviation for "Isaias" and "Rev" as abbreviation for "Apocalipsis".

see latest code: Latest Code

[JerwellSavella]

Thanks for the code Kuya @venjot! , I submitted a PR to the feature/add-bible-languages branch to add Tagalog Abbreviation as well. I will also do some tests on the latest code. Thanks po!

[venjot]

Hi @JerwellSavella , I have approved the pull request :) thanks for adding abbreviation for tagalog.

[SanSon97]

Thank you all for making the app available in Spanish. Regarding JW Library, the issue is not in the link, I found the way to opening the link in the app. 

[SanSon97]

Found this ones on this week's study article:

Salmo= Sal.
Proverbios= Prov.
Ezequiel= Ezeq.
Mateo = Mat.
Lucas = Luc.
Hechos= Hech.
Romanos= Rom.
Efesios = Efes.
2 Tesalonicenses= 2 Tes.
Hebreos= Heb.
Apocalipsis = Apoc.

[venjot]

Hi @SanSon97 ,
Thank you for this. I will update the abbreviation.

Can you also update the script that you are using? using this Latest Code

I'm not sure if I used the correct bible for my reference previously, I used the bible text below. it seems in my reference, it is "Salmos" not "Salmo". also, Apocalipsis not "Revelación".

but it seems that Apocalipsis and Revelación are both used in Spanish. is Salmos and Salmo both used in Spanish as well?

[SanSon97]

Dear @venjot I did copy the code but got this error in line 353

[venjot]

Dear @venjot I did copy the code but got this error in line 353

Hi @SanSon97 , May I know what bible you are using and the document you are testing? as I was not able to replicate the issue.

Thank you so much :)

[venjot]

Hi @SanSon97 , I was able to replicate the issue now.

I think you run the AppScript while the "getBibleLink" is selected.

Can you please try to run it while "bibleLinker" is selected? You should not have any issues after running it.

[SanSon97]

Hello @venjot you are using the correct and latest abbreviation, it's just that in some publications it varies. Also, some of those are from the Rbi8. Here is a picture of the 1987 Rbi8.
I'll keep checking for new/different ones.

[venjot]

Hi @SanSon97 , thanks for this. :) I will let you know once I have updated the code for the book names and abbreviations. :)

[SanSon97]

Thank you so much @venjot I noticed only a few differences in both Indexes, the other are new abbreviations found in the newer Magazines. Like this week's study article:

[venjot]

Hi @SanSon97 , We've updated the abbreviation for Spanish.

see the latest code. Code.gs

We've found an issue that we haven't fixed. the issue is it is using "–" rather than "-"
Example:
Génesis 6:1–7:23

We will update you once we fixed it. :)

[venjot]

Hi @SanSon97 , We've already applied the fix for the issue that bible verse is using "–" rather than "-".

Example:
Génesis 6:1–7:23

see latest code: Code.gs

[majal]

Hi everyone!

I had some time to fiddle with the code again after a year. Version 2 is coming.

The main difference with v1 is that all data on v2 is now externally linked via JSON. This will make it easy to customize the Linker for other languages.

All core functions have been rewritten from scratch. Of course it needs testing to see if there are bugs or edge cases.

TO DO:

• Make selections work
• Parse single-chapter Bible verses
• Rewrite the UI

Code:
https://github.com/majal/bible-linker-google-docs/commits/main/Code.gs

Initial data for English:
https://github.com/majal/bible-linker-google-docs/commits/main/bible-data/en_jw.json