Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth redirection has stopped working #2214

Open
chrism opened this issue Jun 11, 2020 · 2 comments
Open

OAuth redirection has stopped working #2214

chrism opened this issue Jun 11, 2020 · 2 comments

Comments

@chrism
Copy link
Contributor

chrism commented Jun 11, 2020

I have a site which has been using Ember Simple Auth (with Torii) to sign in users via a 3rd party service which has all been working fine for a long time.

But at some point this has stopped working now when using Firefox.

Trying to understand what has happened I noticed that the URL in the popup window is now wrong. It seems like Firefox is now automatically redirecting to https (which my site does not support).

The URL is specified in my config is

ENV.torii.providers.3rd-party-service.redirectUri = 'http://www.mysite.com/torii/redirect.html';

But the popup displays https

https-firefox

I have not updated this project for some time and am using Ember Simple Auth v1.2.0.

Is there a simple fix for this that would not require adding https to the site?

@cloke
Copy link

cloke commented Jun 17, 2020

I had the same issue. They've moved config stuff to the routes. Check out the migration guide. https://github.com/simplabs/ember-simple-auth/blob/411c19e2639b1d4c9776647675dd539b1ab788ee/guides/upgrade-to-v3.md

@marcoow
Copy link
Member

marcoow commented Jun 17, 2020

Hm, I'd be surprised if this started to behave differently without any change…

Also, ENV.torii.providers.3rd-party-service.redirectUri = 'http://www.mysite.com/torii/redirect.html'; is a torri config setting that ESA does not use in anyway so I think you'll want check https://github.com/Vestorly/torii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants