Fix reply-to → Reply-To, which prevented mimemail from encoding the header properly

Author: skosch

lib/mailman/parsing.ex

@@ -11,7 +11,7 @@ defmodule Mailman.Parsing do
       subject: get_header(raw, "Subject") || "",
       from: get_header(raw, "From") || "",
       to: get_header(raw, "To") || "",
-      reply_to: get_header(raw, "reply-to") || "",
+      reply_to: get_header(raw, "Reply-To") || "",
       cc: get_header(raw, "Cc") || "",
       bcc: get_header(raw, "Bcc") || "",
       attachments: get_attachments(raw),

lib/mailman/render.ex

@@ -130,7 +130,7 @@ defmodule Mailman.Render do
       { "From", email.from },
       { "To", email.to |> normalize_addresses |> Enum.join(",") },
       { "Subject", email.subject },
-      { "reply-to", email.reply_to },
+      { "Reply-To", email.reply_to },
       { "Cc",  email.cc |> as_list |> normalize_addresses |> Enum.join(", ") |> as_list },
       { "Bcc", email.bcc |> as_list |> normalize_addresses |> Enum.join(", ") |> as_list }
     ] |> Enum.filter(fn(i) -> elem(i, 1) != [] end)

test/mailman_test.exs

@@ -93,7 +93,8 @@ defmodule MailmanTest do
     {:ok, message} = MyApp.Mailer.deliver(testing_email())
     {:ok, parsed_email} = Mailman.Email.parse(message)
 
-    IO.inspect("PARSED EMAIL IS #{inspect parsed_email}")
+    # Un-comment this to investigate problems with parsing
+    # IO.inspect(parsed_email)
 
     assert true
   end
@@ -335,4 +336,27 @@ defmodule MailmanTest do
                email_with_template_paths.data
              )
   end
+
+  def email_with_unicode_in_header do
+    %Mailman.Email{
+      subject: "Hello Mailman!",
+      from: "Some Emoji – 👍 <mailman@elixir.com>",
+      reply_to: "Some more Emoji – 🔥 <reply@example.com>",
+      to: ["Another Emoji – 💕 <ciemniewski.kamil@gmail.com>"],
+      cc: ["Another Emoji! – 🎁 <testy2#tester1234.com>", "abcd@defd.com"],
+      bcc: ["Yet another emoji! – 🌹 <1234@wsd.com>", "Just ASCII <test@example.com>"],
+      text: "Yo, here's one more emoji: 🆕",
+      html: "<div>Yo, here's one more emoji: 🆕</div>",
+    }
+  end
+
+  test "should encode email parts properly" do
+    email_with_unicode_in_header = email_with_unicode_in_header()
+    rendered_email = Mailman.Render.render(email_with_unicode_in_header, %Mailman.EexComposeConfig{})
+
+    # Un-comment this to investigate problems with header encodings
+    # IO.inspect(rendered_email)
+
+    assert true
+  end
 end