Fix NoMethodError in get_bounce and get_complaint #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove explicit nil params argument from get_bounce and get_complaint methods in Suppressions class. After the migration from rest-client to Faraday in 53a8edd, the Client#get method changed to expect params to be a Hash (defaulting to {}), and now calls params[:headers] unconditionally. Passing nil causes "undefined method '[]' for nil:NilClass". get_unsubscribe was already correct (no nil argument), but get_bounce and get_complaint were not updated to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove explicit nil params argument from get_bounce and get_complaint methods in Suppressions class.
After the migration from rest-client to Faraday in 53a8edd, the Client#get method changed to expect params to be a Hash (defaulting to {}), and now calls params[:headers] unconditionally. Passing nil causes "undefined method '[]' for nil:NilClass".
get_unsubscribe was already correct (no nil argument), but get_bounce and get_complaint were not updated to match.