Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does this depend on chi? #332

Open
asmaloney opened this issue Oct 28, 2024 · 3 comments
Open

Why does this depend on chi? #332

asmaloney opened this issue Oct 28, 2024 · 3 comments

Comments

@asmaloney
Copy link

I was surprised to see chi in my dependencies and traced it to mailgun.

What's this used for?

Could it be replaced by go 1.22's new routing?

Thanks!

@vtopc
Copy link
Contributor

vtopc commented Oct 28, 2024

Hey. I replied in #322 (comment)

What's this used for?

It's used for mocks(don't ask why it's not a part of _test), and mocks are used by a lot of people - #323 (comment)

@loeffel-io

This comment was marked as off-topic.

@vtopc
Copy link
Contributor

vtopc commented Nov 7, 2024

@asmaloney, I replied in #322 (comment) why 1.22's new routing is bad.
But you can write some wrapper above it, e.g.:

type T struct {
    Method string
    Path/Pattern string
    Handler http.HandlerFunc
}

So feel free to create a PR.

@asmaloney asmaloney removed their assignment Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants