New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the manager macroable #153

Open

indykoning opened this issue Nov 13, 2023 · 0 comments

indykoning commented Nov 13, 2023

By implementing https://laravel.com/api/10.x/Illuminate/Support/Traits/Macroable.html to https://github.com/mailerlite/laravel-elasticsearch/blob/main/src/Manager.php
this will allow additional functions to be added to the Elasticsearch manager.

Making it so if extra customisation, or features need to be added inside of a specific project that it is not necessary to wrap this wrapper.

I think additionally running hasMacro, and if it resolves to true. Running the trait's __call should be enough.
https://github.com/laravel/framework/blob/20085feef61119b58fef540cba79595b4a85a89a/src/Illuminate/Macroable/Traits/Macroable.php#L109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment