Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: maidsafe/qp2p
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.23.0
Choose a base ref
...
head repository: maidsafe/qp2p
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.24.0
Choose a head ref
  • 5 commits
  • 9 files changed
  • 2 contributors

Commits on Oct 20, 2021

  1. refactor: add a Timeout helper trait to tests 

    This makes it much more concise to add timeouts to futures, which is
good because there should be a lot more of them...
    @lionel-faber
    Chris Connelly authored and lionel-faber committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    09bd442 View commit details
    Browse the repository at this point in the history

  2. refactor: add additional timeouts to tests 

    This covers all the `stream.next()` futures, which would otherwise await
forever. This ensures we get a more useful error in these cases, rather
than hung tests.
    @lionel-faber
    Chris Connelly authored and lionel-faber committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    13d382f View commit details
    Browse the repository at this point in the history

  3. fix: don't retry sending on connection loss 

    If the connection is lost, there's not point in trying again to send
using the same connection. This would have to be handled by the caller,
who can choose how to respond (e.g. reconnect and try again, or bail).
    @lionel-faber
    Chris Connelly authored and lionel-faber committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    578936d View commit details
    Browse the repository at this point in the history

  4. refactor!: remove IncomingMessages 

    This is part of the move to a fully connection-oriented API. The
per-connection `ConnectionIncoming` streams must be used instead.

Since `ConnectionIncoming` cannot be cloned (since the inner
`mpsc::Receiver` cannot be cloned), methods that use the connection pool
return an `Option<ConnectionIncoming>`. This also reveals one of the
inconsistencies with the connection pool, in that incoming connections
always come with a `ConnectionIncoming`, since they replace anything
already in the pool.

As with `Connection`, it's currently a connection-pool-specific wrapper
that's returned (`ConnectionIncomingHandle`). This is necessary to
ensure that lost connections are removed from the pool. These wrappers
will go away when the connection pool is removed, and the API should
remain unchanged.

BREAKING CHANGE: `IncomingMessages` has been removed, and is no longer
returned by `Endpoint::new` or `Endpoint::new_client`.
    @lionel-faber
    Chris Connelly authored and lionel-faber committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    c0a6a20 View commit details
    Browse the repository at this point in the history

  5. chore(release): 0.24.0

    @actions-user @MaidSafe-QA
    actions-user authored and MaidSafe-QA committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    0385601 View commit details
    Browse the repository at this point in the history
Loading