Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: maidsafe/qp2p
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.22.1
Choose a base ref
...
head repository: maidsafe/qp2p
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.22.2
Choose a head ref
  • 8 commits
  • 12 files changed
  • 2 contributors

Commits on Oct 13, 2021

  1. ci: update maidsafe/rust-version-bump-branch-creator 

    The new version maintains the format of `Cargo.toml`, so we should be
able to tidy that up a bit.
    @lionel-faber
    Chris Connelly authored and lionel-faber committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    0d8455a View commit details
    Browse the repository at this point in the history

  2. chore: format Cargo.toml and simplify tokio features 

    Having bumped `maidsafe/rust-version-bump-branch-creator`, the
`Cargo.toml` format will be preserved, so we can tidy up the format.

Additionally, only one of the `tokio` features were being used, apart
from `macros` which was only needed for tests.
    @lionel-faber
    Chris Connelly authored and lionel-faber committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    d79a01a View commit details
    Browse the repository at this point in the history

  3. feat: add a counter for opened connections to Endpoint 

    This is behind an `unstable-opened-connection-count` feature flag, so
that it can be removed again in future without a breaking change. The
intention is to use it to get a measure of the current number of
connections that we open in downstream tests, in order to see the effect
of removing the `ConnectionPool` and track down extraneous connections.
    @lionel-faber
    Chris Connelly authored and lionel-faber committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    c6a9a42 View commit details
    Browse the repository at this point in the history

  4. refactor: centralise definition of certificate server name 

    This was declared both in `config` and `endpoint`, but is now exported
from `config` and imported in `endpoint`.
    @lionel-faber
    Chris Connelly authored and lionel-faber committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    c88fbdb View commit details
    Browse the repository at this point in the history

  5. refactor: store less config in Endpoint 

    Most of the values in `InternalConfig` are only used when constructing
the endpoint. In fact, it turns out that only the `RetryConfig` needs to
be remembered (since it gets passed to all opened `Connection`s).
    @lionel-faber
    Chris Connelly authored and lionel-faber committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    6b79435 View commit details
    Browse the repository at this point in the history

  6. refactor: rename connections -> connection_handle 

    This is an internal refactor only, in preparation for replacing most of
the connection machinery with an unpooled implementation.
    @lionel-faber
    Chris Connelly authored and lionel-faber committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    cc6e9fc View commit details
    Browse the repository at this point in the history

  7. refactor: implement a non-pooled Connection 

    This commit adds a `connection` module, which implements a connection
API with no dependencies on the connection pool. Most of the API has
moved from `connection_handle`, but from now `ConnectionHandle` is
still exported as `Connection`.

When used on its own, the new `Connection` API follows the typical
drop-based lifecycle. Once both sides of the API (`Connection` and
`ConnectionIncoming`) are dropped, the connection will close
automatically. However, for compability in the short term the `Endpoint`
APIs will still put these `Connection`s in the connection pool, and poll
for incoming messages in a background task, so for now connections will
still remain open until error or explicit close.
    @lionel-faber
    Chris Connelly authored and lionel-faber committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    8eaea98 View commit details
    Browse the repository at this point in the history

  8. chore(release): 0.22.2

    @actions-user @MaidSafe-QA
    actions-user authored and MaidSafe-QA committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    a6081f6 View commit details
    Browse the repository at this point in the history
Loading