Skip to content

Commit 25c5d9d

Browse files
gmackallGray Mackall
authored andcommitted
Remove gradle_deprecated_settings test app, and remove reference from lockfile exclusion yaml (flutter#161622)
The test was intentionally broken by flutter#160947. That PR removed the CI configuration to run the test, but the autoroller (which was previously turned off) runs a gradle command in all android subdirectories, so the fact that the directory wasn't deleted is blocking turning the autoroller back on: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8725731612391969937/+/u/run_roll-packages_script/stdout ``` [stderr] * What went wrong: [stderr] A problem occurred evaluating script. [stderr] > You are applying Flutter's main Gradle plugin imperatively using the apply script method, which is not possible anymore. Migrate to applying Gradle plugins with the declarative plugins block: https://flutter.dev/to/flutter-gradle-plugin-apply ``` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Co-authored-by: Gray Mackall <mackall@google.com>
1 parent 310dff2 commit 25c5d9d

File tree

15 files changed

+0
-844
lines changed

15 files changed

+0
-844
lines changed

dev/integration_tests/gradle_deprecated_settings/README.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

dev/integration_tests/gradle_deprecated_settings/android/app/build.gradle

Lines changed: 0 additions & 56 deletions
This file was deleted.

dev/integration_tests/gradle_deprecated_settings/android/app/src/main/AndroidManifest.xml

Lines changed: 0 additions & 41 deletions
This file was deleted.

dev/integration_tests/gradle_deprecated_settings/android/app/src/main/java/com/yourcompany/flavors/MainActivity.java

Lines changed: 0 additions & 9 deletions
This file was deleted.

dev/integration_tests/gradle_deprecated_settings/android/build.gradle

Lines changed: 0 additions & 50 deletions
This file was deleted.

dev/integration_tests/gradle_deprecated_settings/android/buildscript-gradle.lockfile

Lines changed: 0 additions & 153 deletions
This file was deleted.

dev/integration_tests/gradle_deprecated_settings/android/gradle.properties

Lines changed: 0 additions & 3 deletions
This file was deleted.

dev/integration_tests/gradle_deprecated_settings/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)