Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more reviews (and similar "events"), alongside topic posts #58

Open
mogorman opened this issue Jan 3, 2019 · 5 comments
Open

Show more reviews (and similar "events"), alongside topic posts #58

mogorman opened this issue Jan 3, 2019 · 5 comments
Labels
area: topic info enhancement New feature or request

Comments

@mogorman
Copy link

mogorman commented Jan 3, 2019

We use the github feature for marking a pr reviewed. the posts it generates in the topic don't seem to show up for me. Other posts entered on the pr do seem to show up so not sure where the problem might be.

@tarsius tarsius added the enhancement New feature or request label Jan 3, 2019
@tarsius
Copy link
Member

tarsius commented Jan 3, 2019

Github doesn't treat these events as "posts". But this information is useful and eventually Forge will fetch and display it.

@vermiculus
Copy link
Contributor

vermiculus commented Jan 3, 2019

Design-wise, would you consider them posts, a post subclass, or a different type entirely?

@mogorman mogorman changed the title reviews not showing up in a topic [feature request] reviews not showing up in a topic Jan 3, 2019
@mogorman
Copy link
Author

mogorman commented Jan 3, 2019

cool @tarsius changed topic. thanks for info. magit is amazing as im sure you already know.

@tarsius tarsius changed the title [feature request] reviews not showing up in a topic Show more information about a topic, alongside its posts Jan 3, 2019
@tarsius
Copy link
Member

tarsius commented Jan 3, 2019

I don't know yet.

We could also treat posts as a subtype of a new event type. That's what Gitlab does.

So with Gitlab we get those non-post events for free (especially after b019dfa), but there are other problems. As mentioned in that commit, events have no "subtype" field (at least I didn't see something like that when I last checked). And Gitlab additionally supports "threads" which are secondary discussions attached to a topic that are separate from the "normal posts" and "non-post events". I haven't looked into this any further, but it looked messy at first sight.

@thomas-riccardi
Copy link

Github CI integration result is another type of information about a topic that could usefully be displayed in forge.

@tarsius tarsius changed the title Show more information about a topic, alongside its posts Show more reviews (and similar "events"), alongside topic posts Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: topic info enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants