ACP2E-1958: avoid reloading configs for each requested key; added unit tests

alzota · o-iegorov · commit f0d1035727f5 · 2023-06-01T12:39:47.000-05:00
diff --git a/lib/internal/Magento/Framework/Module/ModuleList.php b/lib/internal/Magento/Framework/Module/ModuleList.php
@@ -140,9 +140,11 @@ public function isModuleInfoAvailable()
      */
     private function loadConfigData()
     {
-        $config = $this->config->get(ConfigOptionsListConstants::KEY_MODULES);
-        if (null === $this->configData && null !== $config) {
-            $this->configData = $config;
+        if (null === $this->configData) {
+            $config = $this->config->get(ConfigOptionsListConstants::KEY_MODULES);
+            if (null !== $config) {
+                $this->configData = $config;
+            }
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -140,9 +140,11 @@ public function isModuleInfoAvailable()`
`140`	`140`	`*/`
`141`	`141`	`private function loadConfigData()`
`142`	`142`	`{`
`143`		`- $config = $this->config->get(ConfigOptionsListConstants::KEY_MODULES);`
`144`		`- if (null === $this->configData && null !== $config) {`
`145`		`- $this->configData = $config;`
	`143`	`+ if (null === $this->configData) {`
	`144`	`+ $config = $this->config->get(ConfigOptionsListConstants::KEY_MODULES);`
	`145`	`+ if (null !== $config) {`
	`146`	`+ $this->configData = $config;`
	`147`	`+ }`
`146`	`148`	`}`
`147`	`149`	`}`
`148`	`150`