Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove forbidden @author tag from Magento_Backup and Magento_Bundle #36979

Open
wants to merge 8 commits into
base: 2.4-develop
Choose a base branch
from
Open

Remove forbidden @author tag from Magento_Backup and Magento_Bundle #36979

wants to merge 8 commits into from

Conversation

fredden
Copy link
Member

@fredden fredden commented Mar 6, 2023 •
edited by m2-assistant bot
Loading

Description

According to https://devdocs.magento.com/guides/v2.4/coding-standards/docblock-standard-general.html#documentation-space, the @author tag is not permitted in Magento. This pull request removes this tag from the Magento_Backup and Magento_Bundle modules. Given there are so many instances of this tag, I've opened a small pull request to get the process started. I expect that the linter will force me to fix several other coding standards violations on the way, so having a smaller pull request means that task is easier to manage. I plan to open more pull requests to tackle the other instances of this tag.

See also magento/magento-coding-standard#382 and magento/magento-coding-standard#167

See also #36304, #36976, #36977, #36978

Manual testing scenarios

There are not code changes in this pull request. This pull request only removes forbidden comments.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Remove forbidden @author tag from Magento_Backup and Magento_Bundle #37244: Remove forbidden @author tag from Magento_Backup and Magento_Bundle

@m2-assistant
Copy link

m2-assistant bot commented Mar 6, 2023

Hi @fredden. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Fisheye partners-contribution Pull Request is created by Magento Partner labels Mar 6, 2023
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

This was referenced Mar 6, 2023
Open
Merged
Merged
Open
Open
Open
Open
Open
Merged
Merged
Open
Open
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

leonhelmus
leonhelmus approved these changes Mar 20, 2023
View reviewed changes
Copy link

@leonhelmus leonhelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@leonhelmus
Copy link

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Mar 20, 2023
Open
5 tasks
This was referenced Mar 20, 2023
Closed
Closed
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Lima
Copy link
Contributor

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:

  • Verified @author tag got removed from Magento_Bundle && Magento_Backupmodule.

Before: ✖️
Screenshot 2023-04-04 at 12 38 15 PM
Screenshot 2023-04-04 at 12 38 35 PM

After: ✔️
Screenshot 2023-04-04 at 12 46 00 PM
Screenshot 2023-04-04 at 12 46 10 PM

No addiitional manual test cases is required for the regression as this PR related to the removal of the @author tag from the Magento_Bundle && Magento_Backupmodule.

Multiple builds are failing hence, moving this PR to Extended Testing

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests

@engcom-Charlie engcom-Charlie self-assigned this Jun 12, 2024
@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Jun 12, 2024 •
edited
Loading

Implemented a fix for SVC failure.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests

@engcom-Charlie
Copy link
Contributor

Few of the functional B2B, CE, EE and WebAPI failures are different in latest 2 build results, seems to be flaky and the consistent one in both the builds are known issues. Hence moving this PR to Merge in Progress.

Functional B2B: Run 1:
image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36979/148f512f36a61c01b8e56b958c25362b/Functional/allure-report-b2b/index.html
image

Known issues:

  1. #ACQE-6695: TierPricingWhenPriceScopeIsWebsiteWorkingProperlyWithMultipleCurrenciesConfiguredTest
  2. #ACQE-6523: AdminReorderWithCatalogPriceRuleDiscountTest
  3. #ACQE-6648: StorefrontUpdateCustomerAddressBelgiumTest

Functional CE: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36979/aa0f4e0a9cd25dbb487c4d8746bc2b03/Functional/allure-report-ce/index.html#categories/b9b96e4c148bf2a52e53da9c81ddc455/de6c7fb1c5b52ad5/
image

RUN 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36979/aa0f4e0a9cd25dbb487c4d8746bc2b03/Functional/allure-report-ce/index.html
image

Known issues:

  1. #ACQE-6695: TierPricingWhenPriceScopeIsWebsiteWorkingProperlyWithMultipleCurrenciesConfiguredTest
  2. #ACQE-6648: StorefrontUpdateCustomerAddressBelgiumTest
  3. #ACQE-6694: AdminCreateOrderWithCustomerWithoutEmailTest

Functional EE: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36979/a6cf00971914c2a2e4d36c150068b120/Functional/allure-report-ee/index.html#categories
image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36979/14934a70ba689764578b58db55e96ec1/Functional/allure-report-ee/index.html
image

Known issues:

  1. #ACQE-6331: StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest
  2. #ACQE-6694: AdminCreateOrderWithCustomerWithoutEmailTest
  3. #ACQE-6695: TierPricingWhenPriceScopeIsWebsiteWorkingProperlyWithMultipleCurrenciesConfiguredTest

Web API test: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36979/d518417961eb4ee4c5aa4292009a34c6/WebApi/console-error-logs.html
image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36979/8f5c1de688dfd903236449dc041581d2/WebApi/console-error-logs.html
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonhelmus leonhelmus leonhelmus approved these changes

Assignees

@leonhelmus leonhelmus

@engcom-Charlie engcom-Charlie

@engcom-Lima engcom-Lima

Labels
Partner: Fisheye partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Remove forbidden @author tag from Magento_Backup and Magento_Bundle
6 participants
@fredden @leonhelmus @ihor-sviziev @engcom-Lima @engcom-Charlie @m2-github-services