Skip is_scalar for null values when imploding multiline address

[Zaahed]

Description (*)

A conditional is added to skip the is_scalar check for null values. Null values are treated as an empty string by implode() anyway. Allows a null value for the second street line in API requests.

Fixed Issues (if relevant)

1. Fixes 2.4.3-p1 - Magento\Customer\Model\Address\AbstractAddress::_implodeArrayValues($value) #35160

Manual testing scenarios (*)

1. Create an empty guest cart with GraphQL.
   

2. Set the shipping address using the cart_id that was returned from the previous request (see DevDocs). Use null as the second value in the street array.
   

Before the change it will return The address failed to save. Verify the address and try again., after the change it will work as usual.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Zaahed. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Zaahed]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Zaahed]

@magento run Functional Tests CE, Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Zaahed]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Zaahed]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Zaahed]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Zaahed]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-November]

Hi @Zaahed ,
Development team has started working on the issue.
Thank you.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[abhattGlo]

@magento run WebAPI Tests,Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Echo]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Echo]

Functional Tests EE failures are different on last two run on same commit.
Run1

Run2

[engcom-Lima]

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:

• Create empty cart devdocs.
• Set the shipping address using the cart_id that was returned from the previous request (see DevDocs). Use null as the second value in the street array.
  For ex- street: ["Lorem ipsum dolor sit ame", null] in the mutation.

mutation {
 setShippingAddressesOnCart(
  input: {
   cart_id: "{{cart}}"
   shipping_addresses: [
    {
     address: {
      country_code: "FR"
      street: ["Lorem ipsum dolor sit ame", null]
      telephone: "0601020304"
      postcode: "56590"
      city: "PARIS"
      firstname: "B"
      lastname: "C"
      save_in_address_book: false
     }
    }
   ]
  }
 ) {
  cart {
   shipping_addresses {
    firstname
    lastname
    company
    street
    city
    postcode
    country {
     code
     label
    }
    telephone
   }
  }
 }
}

Before: ✖️ Adding null in the street array giving error in the response The address failed to save. Verify the address and try again.

After: ✔️ No error in the response.

Additionally tested:
Placed order using guest from graphQL by giving "null" in the street array.

As per the above comment moving this PR to merge in progress.