Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong state for virtual order #35427

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented May 5, 2022

Description (*)

This PR sets correct state for order with virtual product while creating credit memo.

Actual result
I see correct status after credit memo was created for order with virtual product
Screenshot 2022-05-05 at 10 12 33

Fixed Issues (if relevant)

  1. Fixes Virtual refunded orders do not persist closed state when comment is added via Admin #35283

Manual testing scenarios (*)

  1. Steps provided in Virtual refunded orders do not persist closed state when comment is added via Admin #35283

@m2-assistant
Copy link

m2-assistant bot commented May 5, 2022

Hi @Usik2203. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-github-services m2-github-services added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 5, 2022
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 5, 2022
@Usik2203
Copy link
Contributor Author

Usik2203 commented May 5, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented May 5, 2022

Hi @Usik2203,
I believe this behavior was added in 4f90cf5#diff-4d71d11bfa0a93413b11084af024b82cb95b5169e5c7c5e97d7c7fef2212f151R37

Can we get some info what was context for MC-36533 and make sure we're not breaking it?
Also, would be great to cover your changes with automated tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual refunded orders do not persist closed state when comment is added via Admin
3 participants