Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load color picker dependencies only when it is actually used #34142

Open
wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from
Open

Load color picker dependencies only when it is actually used #34142

wants to merge 6 commits into from

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Sep 22, 2021 •
edited
Loading

Description (*)

Deliver pull request created by krzksz but seem no longer active
All code and commit remain as origin's krzksz

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes [Issue] Load color picker dependencies only when it is actually used #28477

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 22, 2021

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Sep 22, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Sep 23, 2021

@magento run WebAPI Tests, Unit Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn mrtuvn changed the title Draft: Load color picker dependencies only when it is actually used Load color picker dependencies only when it is actually used Sep 24, 2021
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Sep 26, 2021

@magento run Unit Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn mrtuvn added the Area: Perf/Frontend All tickets related with improving frontend performance. label Sep 26, 2021
@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 26, 2021
@in-session
Copy link
Contributor

@magento run Unit Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@in-session
Copy link
Contributor

@mrtuvn
I think the binding would still have to be updated?

magento2/app/code/Magento/Ui/view/base/web/js/lib/knockout/bindings/bootstrap.js

Line 41 in 7c6b636

colorPicker: require('./color-picker')

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Nov 17, 2021

If you interesting to continue with this feel free let me know i will give you access to my repo for update furthers
@in-session

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Dec 6, 2021

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie engcom-Charlie mentioned this pull request Apr 8, 2022
Closed
5 tasks
@engcom-Charlie engcom-Charlie mentioned this pull request Apr 8, 2022
Closed
5 tasks
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 9, 2022

@magento run Functional Tests B2B ,Functional Tests CE ,Functional Tests EE ,Unit Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented May 7, 2022

Seem issue not only from main repo also need update from other repos (MSI, pagebuilder..)

@mrtuvn mrtuvn marked this pull request as draft February 26, 2023 09:52
@Amadeco
Copy link

Amadeco commented Jul 25, 2023

Do we have some news from the Magento Team Core for this PR ?

@kuafucode
Copy link

I'd really love to see this PR merged, it is such a big and outdated lib and probably not used on 99% of the storefront

@mrtuvn mrtuvn marked this pull request as ready for review June 5, 2024 02:24
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 9, 2024

@magento run all tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 10, 2024

@magento run Unit Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Frontend Area: Perf/Frontend All tickets related with improving frontend performance. Component: Checkout Component: Ui help wanted Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Load color picker dependencies only when it is actually used
6 participants
@mrtuvn @in-session @engcom-Charlie @Amadeco @kuafucode @magento-engcom-team