[WIP] Add deprecation for passing incorrect type to Escaper

[ihor-sviziev]

Description (*)

This PR continues the work from #33353 by adding deprecation notice.
There additional changes should be applier for that, so I decided to extract it to a separate PR.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ihor-sviziev. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@magento run Unit Tests, Static Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run Unit Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

Suggested change

	if($deprecatedType) {
	if ($deprecatedType) {

[ihor-sviziev]

Todo:

• looks like in the case of user deprecations, we'll have an exception, while we should have just log record in logs. Need to double-check it https://github.com/magento/magento2/blob/2.4-develop/lib/internal/Magento/Framework/App/ErrorHandler.php#L47-L62
• For some reason, if you're running only a single test, it fails with an error (different exception type returned).
  Workaround: comment the following code: 60e35f5#diff-6e79c25b55077f8880122f3cfbad8e6613e5638ce89fac54ecaf08b1914be58aR17

This commit was added in order to fix the following issues:

PHP Notice:  Undefined property: Magento\Customer\Api\CustomerRepositoryTest::$customerRepository in /opt/bamboo/builds/M2-L1-RB/build-31/dev/tests/integration/framework/Magento/TestFramework/Workaround/Cleanup/TestCaseProperties.php on line 28

PHP Notice:  Undefined property: Magento\Customer\Api\AccountManagementTest::$accountManagement in /opt/bamboo/builds/M2-L1-RB/build-31/dev/tests/integration/framework/Magento/TestFramework/Workaround/Cleanup/TestCaseProperties.php on line 28

PHP Notice:  Undefined property: Magento\Integration\Model\IntegrationTest::$integration in /opt/bamboo/builds/M2-L110-RB/build-2/dev/tests/integration/framework/Magento/TestFramework/Workaround/Cleanup/TestCaseProperties.php on line 28