Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validate-emails rule for ui component #33470

Open
wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

tuanpht
Copy link

@tuanpht tuanpht commented Jul 13, 2021

Description (*)

Fix validation rule validate-emails for using in ui-component:

  • Fix wrong method strip() => trim()
  • Sync logic with lib/web/mage/validation.js

Example usage:

<field name="description" formElement="textarea">
    <settings>
        <validation>
            <rule name="validate-emails" xsi:type="boolean">true</rule>
        </validation>
        <dataType>text</dataType>
        <label translate="true">Emails</label>
        <visible>true</visible>
        <dataScope>emails</dataScope>
    </settings>
</field>

image

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix validate-emails rule for ui component #38528: Fix validate-emails rule for ui component

- Fix wrong method `strip()` => `trim()`
- Sync logic with `lib/web/mage/validation.js`
@m2-assistant
Copy link

m2-assistant bot commented Jul 13, 2021

Hi @tuanpht. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Jul 13, 2021

Hi @tuanpht, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@tuanpht tuanpht reopened this Jul 13, 2021
@tuanpht tuanpht closed this Jul 13, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jul 13, 2021

Hi @tuanpht, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@tuanpht tuanpht reopened this Jul 13, 2021
@tuanpht tuanpht closed this Jul 13, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jul 13, 2021

Hi @tuanpht, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@tuanpht tuanpht reopened this Jul 13, 2021
@tuanpht
Copy link
Author

tuanpht commented Jul 13, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@tuanpht
Copy link
Author

tuanpht commented Jul 14, 2021

Failed Functional Tests are not related. What should I do?

@Den4ik
Copy link
Contributor

Den4ik commented Jul 16, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Delta engcom-Delta added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Dec 13, 2023
@engcom-Delta
Copy link
Contributor

@magento create issue

@Den4ik
Copy link
Contributor

Den4ik commented Mar 18, 2024

@magento run all tests

@Den4ik
Copy link
Contributor

Den4ik commented Mar 19, 2024

@magento run Static Tests

1 similar comment
@Den4ik
Copy link
Contributor

Den4ik commented Mar 19, 2024

@magento run Static Tests

@engcom-Dash engcom-Dash self-assigned this Sep 30, 2024
@engcom-Dash
Copy link
Contributor

Manual testing is not required as this change replaces the incorrect strip method with the correct trim method, ensuring proper string handling; the regex update also enhances email validation by supporting a wider range of characters, including special ones.

Builds are failed. Hence, moving this PR to Extended Testing.

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Static Tests, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento run Static Tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

Moving to merge in progress.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Cleanup Component: Ui Priority: P3 May be fixed according to the position in the backlog. Progress: ready for testing Release Line: 2.4 Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Merge in Progress
Development

Successfully merging this pull request may close these issues.

[Issue] Fix validate-emails rule for ui component
7 participants