-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validate-emails rule for ui component #33470
base: 2.4-develop
Are you sure you want to change the base?
Conversation
- Fix wrong method `strip()` => `trim()` - Sync logic with `lib/web/mage/validation.js`
Hi @tuanpht. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @tuanpht, thank you for your contribution! |
Hi @tuanpht, thank you for your contribution! |
Hi @tuanpht, thank you for your contribution! |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Failed Functional Tests are not related. What should I do? |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento create issue |
@magento run all tests |
@magento run Static Tests |
1 similar comment
@magento run Static Tests |
Manual testing is not required as this change replaces the incorrect strip method with the correct trim method, ensuring proper string handling; the regex update also enhances email validation by supporting a wider range of characters, including special ones. Builds are failed. Hence, moving this PR to Extended Testing. |
@magento run all tests |
@magento run Static Tests, Functional Tests B2B |
@magento run Static Tests |
@magento run all tests |
@magento run Functional Tests CE, Functional Tests B2B |
Description (*)
Fix validation rule
validate-emails
for using in ui-component:strip()
=>trim()
lib/web/mage/validation.js
Example usage:
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: