-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vimeo video play issue after clicking play icon #33407
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @ashar01. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @ashar01, thank you for your contribution! |
Hi @ashar01, thank you for your contribution! |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests CE, Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento create issue |
Thanks for your contribution and collaboration @ashar01 and @Den4ik |
Further investigating more - found one reproduceable case mentioned here. |
Description (*)
Vimeo video does't play video after clicking play button on video thumbnail of product page. Instead it shows another play icon in iframe.
It needs 3 clicks to play a vimeo video.
1 - Click on Video icon on left panel.
2 - Click play icon on thumbnail.
3 - Then Click on another play icon.
Expected Result:
It plays vimeo video when we click on play button.
Advance browsers like FireFox, Chrome and Safari are now blocking video autoplay by default. Chrome auto play policy https://developers.google.com/web/updates/2017/09/autoplay-policy-changes.
To fix this issue i added muted=1 in iframe url. After adding muted=1 it plays video by clicking play icon one time.
Related Pull Requests
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: