Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo video play issue after clicking play icon #33407

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

ashar01
Copy link

@ashar01 ashar01 commented Jul 2, 2021

Description (*)

Vimeo video does't play video after clicking play button on video thumbnail of product page. Instead it shows another play icon in iframe.
It needs 3 clicks to play a vimeo video.
1 - Click on Video icon on left panel.
2 - Click play icon on thumbnail.
3 - Then Click on another play icon.

Expected Result:
It plays vimeo video when we click on play button.

Advance browsers like FireFox, Chrome and Safari are now blocking video autoplay by default. Chrome auto play policy https://developers.google.com/web/updates/2017/09/autoplay-policy-changes.

To fix this issue i added muted=1 in iframe url. After adding muted=1 it plays video by clicking play icon one time.

Related Pull Requests

Manual testing scenarios (*)

  1. ... Open product page.
  2. ... Select video from gallary.
  3. ... Click on play button.
  4. ... It plays vimeo video.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Vimeo video play issue after clicking play icon #33417: Vimeo video play issue after clicking play icon

@m2-assistant
Copy link

m2-assistant bot commented Jul 2, 2021

Hi @ashar01. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Jul 3, 2021

Hi @ashar01, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ashar01 ashar01 reopened this Jul 3, 2021
@ashar01 ashar01 closed this Jul 3, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jul 3, 2021

Hi @ashar01, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ashar01 ashar01 reopened this Jul 3, 2021
@ashar01
Copy link
Author

ashar01 commented Jul 3, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ashar01
Copy link
Author

ashar01 commented Jul 3, 2021

@magento run Functional Tests CE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented Jul 5, 2021

@magento create issue

@Den4ik Den4ik self-requested a review July 5, 2021 06:46
@Den4ik Den4ik self-assigned this Jul 5, 2021
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 26, 2021
@engcom-Alfa
Copy link
Contributor

Thanks for your contribution and collaboration @ashar01 and @Den4ik
The relevant issue got closed since it was not reproducible and there was no reply even after 14 days. Giving a second try to reproduce the issue at the earliest. Kindly give an additional information if anything more can be provided.
Also kindly re-try to reproduce from your end in 2.4-develop if the issue is still existing!
Thanks for your patience!

@engcom-Alfa
Copy link
Contributor

Further investigating more - found one reproduceable case mentioned here.

@engcom-Alfa engcom-Alfa removed the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 9, 2021
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: ProductVideo Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Vimeo video play issue after clicking play icon
4 participants