Skip to content

Added password reset service email config. Using this config for gett… #32883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

vlmed
Copy link
Contributor

@vlmed vlmed commented Apr 27, 2021

Description (*)

I have created new following configs:

  1. Stores->Configuration->Customer->Customer Configuration->Password Options->Password Reset Service Email.
    1619519920005

This config allows change email in the We received too many requests for password resets. Please wait and try again later or contact hello@example.com message. This message appears when customer requested few times password reset.
1619520007499

  1. Stores->Configuration->Advanced->Admin->Security->Password Reset Service Email.
    1619530406555
    This config allows change email in the We received too many requests for password resets. Please wait and try again later or contact hello@example.com message. This message appears when admin user requested few times password reset.
    1619530334808

I created a new configurations because I think it's a bad idea to use a configuration from the Magento Contact module.

Fixed Issues (if relevant)

  1. Fixes Password reset error message references hello@example.com which cannot be changed unless contact form is enabled #32837

Manual testing scenarios (*)

Scenario 1. Reset Customer password

  1. Change email in the config Stores->Configuration->Customer->Customer Configuration->Password Options->Password Reset Service Email. For example (test@example.com)
    1619520136713

  2. On the password reset route (/customer/account/forgotpassword/) request a password reset multiple times. Assuming out-of-the-box configuration you will eventually get the error message that contain email from previous step:
    We received too many requests for password resets. Please wait and try again later or contact test@example.com
    1619520112569

Scenario 2. Reset Admin password

  1. Change email in the config Stores->Configuration->Customer->Customer Configuration->Password Options->Password Reset Service Email. For example (test1@example.com)
    1619530444257

  2. On the password reset route (admin/auth/forgotpassword/) request a password reset multiple times. Assuming out-of-the-box configuration you will eventually get the error message that contain email from previous step:
    We received too many requests for password resets. Please wait and try again later or contact test1@example.com
    1619530533123

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 27, 2021

Hi @vlmed. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Security Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 27, 2021
@vlmed
Copy link
Contributor Author

vlmed commented Apr 27, 2021

@magento run all tests

@vlmed vlmed force-pushed the password_reset_message_email branch from 5a1fbab to 1795f58 Compare April 27, 2021 13:37
@vlmed
Copy link
Contributor Author

vlmed commented Apr 27, 2021

@magento run all tests

Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vlmed Thanks for you contribution

As I see this changes can't be merged into the patch release, because improving admin interface.
I agree with this improvements, but looks like this changes should be approved by Product Owner the first

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Apr 27, 2021
@vlmed
Copy link
Contributor Author

vlmed commented Apr 28, 2021

@magento run Functional Tests EE, Functional Tests B2B

@vlmed
Copy link
Contributor Author

vlmed commented Apr 28, 2021

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

No builds to run for your request.

@Den4ik
Copy link
Contributor

Den4ik commented Apr 28, 2021

@magento run Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented Apr 30, 2021

@magento run Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented Apr 30, 2021

@magento-engcom-team Could someone assist with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Security Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: review Release Line: 2.4
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

Password reset error message references hello@example.com which cannot be changed unless contact form is enabled
3 participants