-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Added password reset service email config. Using this config for gett… #32883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @vlmed. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
…ing customer or admin service email
5a1fbab
to
1795f58
Compare
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vlmed Thanks for you contribution
As I see this changes can't be merged into the patch release, because improving admin interface.
I agree with this improvements, but looks like this changes should be approved by Product Owner the first
@magento run Functional Tests EE, Functional Tests B2B |
@magento run Functional Tests B2B |
No builds to run for your request. |
@magento run Functional Tests EE, Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests EE, Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento-engcom-team Could someone assist with this PR? |
Description (*)
I have created new following configs:
Stores->Configuration->Customer->Customer Configuration->Password Options->Password Reset Service Email
.This config allows change email in the

We received too many requests for password resets. Please wait and try again later or contact hello@example.com
message. This message appears when customer requested few times password reset.Stores->Configuration->Advanced->Admin->Security->Password Reset Service Email
.This config allows change email in the
We received too many requests for password resets. Please wait and try again later or contact hello@example.com
message. This message appears when admin user requested few times password reset.I created a new configurations because I think it's a bad idea to use a configuration from the
Magento Contact
module.Fixed Issues (if relevant)
Manual testing scenarios (*)
Scenario 1. Reset Customer password
Change email in the config

Stores->Configuration->Customer->Customer Configuration->Password Options->Password Reset Service Email
. For example (test@example.com
)On the password reset route (/customer/account/forgotpassword/) request a password reset multiple times. Assuming out-of-the-box configuration you will eventually get the error message that contain email from previous step:

We received too many requests for password resets. Please wait and try again later or contact test@example.com
Scenario 2. Reset Admin password
Change email in the config

Stores->Configuration->Customer->Customer Configuration->Password Options->Password Reset Service Email
. For example (test1@example.com
)On the password reset route (admin/auth/forgotpassword/) request a password reset multiple times. Assuming out-of-the-box configuration you will eventually get the error message that contain email from previous step:

We received too many requests for password resets. Please wait and try again later or contact test1@example.com
Contribution checklist (*)