Fixes 'unexpected token case' on massaction_extended template

[vrielsa]

Description (*)

When using HTML minification the massaction_extended template (from the Magento_Catalog module) causes a javascript error ('unexpected token case'). Adding proper closing tags to the break statement fixes this.
Also removed deprecated escape calls.

Steps for reproducing the issue

• Create a custom product grid using the app/code/Magento/Catalog/view/adminhtml/templates/product/grid/massaction_extended.phtml template
• Enable HTML minification using Cloudflare
• Visit the page with the custom product grid

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @vrielsa. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[vrielsa]

@magento give me test instance

[magento-deployment-service]

Hi @vrielsa. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @vrielsa, here is your Magento Instance: https://dbf526d7fd7dcf2fe5f8f836e246a95d.instances.magento-community.engineering
Admin access: https://dbf526d7fd7dcf2fe5f8f836e246a95d.instances.magento-community.engineering/admin_26d9
Login: 1f058174
Password: 537e4e5ab018

[vrielsa]

@magento run all tests

[mrtuvn]

@magento run Unit Tests, Functional Tests B2B

[mrtuvn]

cc: @vrielsa can you update PR description steps to reproduce issue for QA can re-check

[mrtuvn]

@gabrieldagama should we need cover this change by some kind of tests

[mrtuvn]

deprecated escape calls still called in another template
reference link below
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/massaction_extended.phtml

[vrielsa]

@mrtuvn I'll update the description later today. I'll update the widget/grid/massaction_extended.phtml as well if you like

[mrtuvn]

Yes you are feel free to do that or maybe do it later via another seperate PR