Deleted lib/internal/Magento/Framework/Filesystem/ExtendedDriverInterface.php. getMetadata() method moved to DataInterface

[vlmed]

Description (*)

What done:

• lib/internal/Magento/Framework/Filesystem/ExtendedDriverInterface.php - deleted
• getMetadata() method was moved to lib/internal/Magento/Framework/Filesystem/DriverInterface.php
• getMetadata() was implemented in the lib/internal/Magento/Framework/Filesystem/Driver/File.php. To avoid code duplication I use lib/internal/Magento/Framework/Filesystem/Driver/File/Mime.php to get file mime type. I can't instantiate this class using ObjectManager because when lib/internal/Magento/Framework/Filesystem/Driver/File.php instantiating first time the ObjectManager isn't instantiated yet (lib/internal/Magento/Framework/Console/Cli.php::assertCompilerPreparation(). So, I decided to implements static method getMimeInstance() in the lib/internal/Magento/Framework/Filesystem/Driver/File/Mime.php and use it in the lib/internal/Magento/Framework/Filesystem/Driver/File.php to get an instance instead of create object directly using construction new Mime().
• getMetadata() was implemented in thelib/internal/Magento/Framework/Filesystem/Driver/StatefulFile.php. This class is deprecated so I used method implementation from the lib/internal/Magento/Framework/Filesystem/Driver/File.php.
• test was implemented on the getMetadata() method in the lib/internal/Magento/Framework/Filesystem/Test/Unit/Driver/FileTest.php
• test was implemented on the getMimeInstance() method in the lib/internal/Magento/Framework/Filesystem/Test/Unit/Driver/File/MimeTest.php

Fixed Issues (if relevant)

1. Fixes Remove deprecated framework interfaces #32331

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @vlmed. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.5-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[vlmed]

@magento run all tests

[vlmed]

@magento run Unit Tests

[vlmed]

@magento run all tests

[vlmed]

@magento run Integration Tests

[eduard13]

@magento run Integration Tests

[eduard13]

@magento run Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

[vlmed]

@magento give me test instance

[magento-deployment-service]

Hi @vlmed. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @vlmed, here is your Magento Instance: https://dbc60479cb03e2647548d7b778ceb157.instances.magento-community.engineering
Admin access: https://dbc60479cb03e2647548d7b778ceb157.instances.magento-community.engineering/admin_a9d9
Login: 45f7c38c
Password: e00b69566027

[eduard13]

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

[eduard13]

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

[eduard13]

Hi @vlmed, could you please review the functional failed builds, looks like they are related to your changes.
We're getting this on customer account create, when using some remote file storage

Thank you.

[eduard13]

Hi @gabrieldagama, could you please help us with the logs here, so we could understand what is going wrong?

Thank you.

[gabrieldagama]

@eduard13 couldn't find a clear exception being thrown here, probably the best way to find out what is going on is to try to reproduce the MFTF manually and identify the difference. Probably we can use the `give me test instance for such test.

[vlmed]

@magento run all tests

[vlmed]

@magento run Integration Tests

[vlmed]

@magento run Integration Tests, Unit Tests

[vlmed]

@magento run all tests

[vlmed]

@magento run all tests

[vlmed]

@magento run all tests

[vlmed]

@magento run all tests