Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of the code #32311

Open
wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from
Open

Refactoring of the code #32311

wants to merge 6 commits into from

Conversation

ejaz-alam
Copy link
Contributor

@ejaz-alam ejaz-alam commented Mar 1, 2021 •
edited by engcom-Dash
Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Refactoring of the code #38503: Refactoring of the code

Resolved issues:

  1. resolves [Issue] Refactoring of the code #39281: Refactoring of the code

@m2-assistant
Copy link

m2-assistant bot commented Mar 1, 2021

Hi @ejaz-alam. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev ihor-sviziev added Cleanup Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Mar 2, 2021
@ihor-sviziev ihor-sviziev self-assigned this Mar 2, 2021
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@sivaschenko sivaschenko added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Mar 2, 2021
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B , Functional Tests CE, WebAPI Tests

ihor-sviziev
ihor-sviziev approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ejaz-alam,
✔ approved!
But as your PR marked as low priority (p4) - this PR will be delivered after all high priority PRs, so it might take some time.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8880 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Mar 8, 2024
Open
4 tasks
@engcom-Delta engcom-Delta added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 13, 2024
@engcom-Dash engcom-Dash self-assigned this Oct 18, 2024
@engcom-Dash
Copy link
Contributor

@magento run all tests

@m2-assistant m2-assistant bot mentioned this pull request Oct 18, 2024
Closed
5 tasks
@engcom-Dash
Copy link
Contributor

Manual testing is not required for this change since the functionality remains unchanged; the logic has been simplified without affecting behavior.

Builds are failed, so moving it to Extended Testing.

@engcom-Dash engcom-Dash force-pushed the patch-3 branch 2 times, most recently from be76111 to 7e6116c Compare October 18, 2024 15:38
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

Hello @ejaz-alam,

Thank you so much for your contribution!

I wanted to reach out to let you know that while I was fixing the static failure on your PR, I unfortunately made a mistake by force-pushing my changes. After doing this, I realized I couldn't find your original commit (which is quite strange). I checked the git log and the orphan log but was unable to locate it. As a result, I reset the branch and pushed a new commit.

I sincerely apologize for this oversight and any inconvenience it may have caused. Thank you for your understanding!

Thanks again!

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Static Tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests CE

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@engcom-Charlie
Copy link
Contributor

The Functional CE failures are not consistent in recent 2 builds. Neither they are part of this PR now failing because of PR changes.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32311/ee190589dadf37eaef40f52cf7f04d92/Functional/allure-report-ce/index.html#categories

image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32311/2af0531e5f5178efa38593820c635240/Functional/allure-report-ce/index.html#categories

image

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Jan 10, 2025 •
edited
Loading

The integration failure in recent 2 builds is a known issue.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32311/134ab72269c8cc040601fcc9a885d496/Integration/console-error-logs.html

image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32311/134ab72269c8cc040601fcc9a885d496/Integration/console-error-logs.html

image

Known Issue:
AC-13584

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Charlie
Copy link
Contributor

The Functional B2B failures are not consistent in recent 2 builds. Neither they are part of this PR now failing because of PR changes. Hence moving this PR to Merge in Progress.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32311/d786c77b538f930c082e52fc27c19d63/Functional/allure-report-b2b/index.html#categories

image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/32311/855a93413af14174d7fdda93ca40057e/Functional/allure-report-b2b/index.html#categories

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Delta engcom-Delta

@engcom-Dash engcom-Dash

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: User Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: ready for testing Release Line: 2.4 Risk: low Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Refactoring of the code [Issue] Refactoring of the code
7 participants
@ejaz-alam @ihor-sviziev @magento-engcom-team @engcom-Delta @engcom-Dash @engcom-Charlie @sivaschenko