Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception handling #31598

Open
wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from
Open

Improve exception handling #31598

wants to merge 6 commits into from

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Jan 8, 2021 •
edited by m2-assistant bot
Loading

Description (*)

When the basic exception appears - we're having mixed HTML and plain text. This PR fixes this.

Before:

❌ <pre> tags are rendered
image

After:

✔ <pre> tags are not rendered
image

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Improve exception handling #38499: Improve exception handling

@m2-assistant
Copy link

m2-assistant bot commented Jan 8, 2021

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev ihor-sviziev added the Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. label Jan 8, 2021
@Stepa4man Stepa4man self-assigned this Jan 8, 2021
@Stepa4man Stepa4man self-requested a review January 8, 2021 12:47
@ihor-sviziev
Copy link
Contributor Author

@magento run Unit Tests

@ihor-sviziev
Copy link
Contributor Author

@magento run Unit Tests

@Stepa4man Stepa4man added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 8, 2021
@ihor-sviziev
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev
Copy link
Contributor Author

@Stepa4man pls review, tests are passing now

Stepa4man
Stepa4man approved these changes Jan 10, 2021
View reviewed changes
Copy link
Contributor

@Stepa4man Stepa4man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ihor-sviziev
Thanks for your contribution

@magento-engcom-team
Copy link
Contributor

Hi @Stepa4man, thank you for the review.
ENGCOM-8611 has been created to process this Pull Request

@gabrieldagama gabrieldagama added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Jan 14, 2021
@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, thank you for the review.
ENGCOM-8611 has been created to process this Pull Request

@hostep
Copy link
Contributor

hostep commented Jul 28, 2021

Great to see progress in a PR with prio P4, let's hope other PR's with low prio that have been open since ages will now also finally get processed ... 😉

@engcom-Delta
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Mar 8, 2024
Open
4 tasks
@engcom-Delta engcom-Delta added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 15, 2024
@engcom-Dash engcom-Dash self-assigned this Oct 18, 2024
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

Manual testing is not required since it changes the header from plain text to HTML for better visibility of exceptions.

Build are failed, so moving it to Extended Testing.

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

The Functional B2B test failures are different in recent 2 successive builds. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31598/210e366ab0feebdceda8301b291d4231/Functional/allure-report-b2b/index.html#categories/39002bb4b823f2d59e22404a186a7115/919ddc55455fec31/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31598/1bb0bd64d27bcd6e278f02a4a100d27c/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741
image

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Oct 29, 2024 •
edited
Loading

Hello @ihor-sviziev,

Thanks for your contributions!

Moving this PR to on hold since it’s a feature request and we need PO approval for it. Once we get approval, we will proceed accordingly.

Thanks.

@engcom-Dash
Copy link
Contributor

Hello @ihor-sviziev,

We have received the go-ahead on this PR from the PO. We are moving it to extended testing for now to analyze the build results with the latest code.

Thanks.

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

We have a green build so moving it to "Merge in Progress".
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stepa4man Stepa4man Stepa4man approved these changes

@Den4ik Den4ik Den4ik approved these changes

Assignees

@Den4ik Den4ik

@Stepa4man Stepa4man

@engcom-Dash engcom-Dash

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: App Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: ready for testing Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Improve exception handling
8 participants
@ihor-sviziev @magento-engcom-team @hostep @engcom-Delta @engcom-Dash @Den4ik @Stepa4man @gabrieldagama