Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#31361: Magento 2 custom attribute filter not working… #31481

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

sasha19957099
Copy link
Contributor

@sasha19957099 sasha19957099 commented Dec 29, 2020

Description (*)

Attribute values mapping was incorrect for inputs of 'select' type so GraphQL products query couldn't filter by the attributes.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Magento 2 custom attribute filter not working graphql products query in product attribute custom source #31361

Manual testing scenarios (*)

See here #31361

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…products query in product attribute custom source - fixed attribute values mapping for inputs of select type
@m2-assistant
Copy link

m2-assistant bot commented Dec 29, 2020

Hi @sasha19957099. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sasha19957099
Copy link
Contributor Author

@magento run all tests

@sasha19957099 sasha19957099 self-assigned this Dec 29, 2020
@gabrieldagama gabrieldagama added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Mar 18, 2021
@nuzil
Copy link
Contributor

nuzil commented Sep 8, 2022

I can confirm that this bus is still there on 2.4.5 and this fix it still works!
thanks!

@engcom-Hotel
Copy link
Contributor

Hello @sasha19957099,

Thanks for the contribution!

We are unable to reproduce the issue. Please refer to this #31361 (comment), and provide us the details, if we missed anything.

Thanks

@andrewbess andrewbess self-assigned this Jan 22, 2024
@andrewbess
Copy link

Hello @sasha19957099
Thank you for collaboration
I'll try to reproduce it on the local environment and return to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Elasticsearch Component: Test PAP Partners acceleration program Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: review Project: GraphQL Release Line: 2.4
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

Magento 2 custom attribute filter not working graphql products query in product attribute custom source
8 participants