magento/magento2#31206: Selected shipping method does not contain val…

[sasha19957099]

Description (*)

Added values to GraphQL schema price_excl_tax price_incl_tax for Selected shipping method

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes [GraphQl] Selected shipping method does not contain value including tax. #31206

Manual testing scenarios (*)

1.Enable the shipping method flatrate and set its price to 10
2. Configure a default tax class for shipping that's not 0%. My example is 21%
3. Set tax/calculation/shipping_includes_tax to "Including Tax"
4. Set tax/cart_display/shipping to "Including Tax"
5. Set tax/display/shipping to "Including Tax"
6. Create a Cart through GraphQl
7.Add a product to your cart through GraphQl
8.Set a Shipping Address on your cart through GraphQl
9. Set flatrate/flatrate as your shipping method through GraphQl using the following query.

mutation setShippingMethodsOnCart($cartId: String!) {
setShippingMethodsOnCart(input: {cart_id: $cartId, shipping_methods: [{carrier_code: "flatrate", method_code: "flatrate"}]}) {
cart {
shipping_addresses {
selected_shipping_method {
amount {
currency
value
}
price_excl_tax {
currency
value
}
price_incl_tax {
currency
value
}
}
available_shipping_methods{
amount {
currency
value
}
price_excl_tax {
currency
value
}
price_incl_tax {
currency
value
}
}
}
}
}
}

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @sasha19957099. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[sasha19957099]

@magento run all tests

[victorchiriac89]

Any news over this, when will it be included?

[cpartica]

First option:
'price' word should be change to 'amount' resulting in
amount_excl_tax: Money!
amount__incl_tax: Money!

Second option:
amount and prices can't be used interchangeably
amount should either be removed or renamed to display_price or removed

[engcom-Alfa]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

@magento run Functional Tests B2B, Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

@magento run Functional Tests B2B, Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

✔️ QA Passed

This PR was requested for changes as per the above comment, and the fix has already covered with GraphQL auto-test case.
Hence no further QA investigation required and hence moving it ahead!

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Charlie]

As the build is green now and as per this comment PR is QA passed so moving it to Merge in Progress.

Thank you!