Missing unique key on eav attribute label table #30981

alex311982 · 2020-11-19T10:36:48Z

Description (*)
The table eav_attribute_label should contain a unique key constraint on the (store_id, attribute_id) pair.
This PR add it. Fixes #24581

Contribution checklist (*)
Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-11-19T10:36:50Z

Hi @alex311982. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

alex311982 · 2020-11-19T10:38:47Z

@magento run Functional Tests B2B

alex311982 · 2020-11-19T13:25:47Z

@magento run Functional Tests EE

ihor-sviziev · 2020-11-19T13:28:37Z

Hi @alex311982,
I believe you're trying to fix the #24581?
If so - could you add to description following text:
Fixes #24581 ?

ihor-sviziev · 2020-11-19T13:28:48Z

@magento run all tests

alex311982 · 2020-11-19T13:33:29Z

@ihor-sviziev The description is updated.

ihor-sviziev · 2020-11-19T13:46:03Z

Just copied priority and severity labels from issue.

The changes looks good to me, but let's wait for test results

ihor-sviziev · 2020-11-19T19:40:52Z

@magento run all tests

alex311982 · 2020-11-20T09:40:41Z

@magento run all tests

ihor-sviziev · 2020-11-20T10:00:46Z

app/code/Magento/Eav/etc/db_schema.xml

@@ -486,6 +486,10 @@
                    referenceColumn="attribute_id" onDelete="CASCADE"/>
        <constraint xsi:type="foreign" referenceId="EAV_ATTRIBUTE_LABEL_STORE_ID_STORE_STORE_ID" table="eav_attribute_label"
                    column="store_id" referenceTable="store" referenceColumn="store_id" onDelete="CASCADE"/>
+        <constraint xsi:type="unique" referenceId="EAV_ATTRIBUTE_LABEL_ATTRIBUTE_ID_STORE_ID_UNIQUE">


Seems like the name should be, as you have different soring of the columns, also "_UNIQUE" suffix isn't really needed here

Suggested change

<constraint xsi:type="unique" referenceId="EAV_ATTRIBUTE_LABEL_ATTRIBUTE_ID_STORE_ID_UNIQUE">

<constraint xsi:type="unique" referenceId="EAV_ATTRIBUTE_LABEL_STORE_ID_ATTRIBUTE_ID">

ihor-sviziev · 2020-11-20T10:01:07Z

app/code/Magento/Eav/etc/db_schema_whitelist.json

@@ -390,4 +392,4 @@
            "EAV_FORM_ELEMENT_TYPE_ID_ATTRIBUTE_ID": true
        }
    }
-}
+}


Please add empty line to the file, as it was before

app/code/Magento/Eav/etc/db_schema_whitelist.json

engcom-Alfa · 2022-06-06T10:04:53Z

We have a couple of auto-test jobs being failed after many tried. Hence moving the PR ticket to Extended Testing.

engcom-Charlie · 2022-06-06T13:33:34Z

@magento run Functional Tests EE, Semantic Version Checker

magento-automated-testing · 2022-06-06T13:33:43Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…e-key-on-eav_attribute_label-table

engcom-Charlie · 2022-06-07T06:39:13Z

@magento run all tests

magento-automated-testing · 2022-06-07T06:39:21Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-06-07T09:18:52Z

@magento run Functional Tests B2B, Functional Tests EE, Semantic Version Checker, Functional Tests CE

magento-automated-testing · 2022-06-07T09:18:56Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-06-07T14:36:46Z

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B, Semantic Version Checker

magento-automated-testing · 2022-06-07T14:36:51Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-06-08T06:50:43Z

@magento run Functional Tests B2B, Functional Tests CE, Semantic Version Checker

magento-automated-testing · 2022-06-08T06:50:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-06-08T14:36:07Z

@magento run Functional Tests CE, Semantic Version Checker

magento-automated-testing · 2022-06-08T14:36:17Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-06-09T11:05:11Z

Created Approval Jira ticket for the SVC test failure. Waiting for the approvals.

Moving it to Pending Approval now.

Thank you!

engcom-Charlie · 2022-10-21T12:02:55Z

Created new Approval Jira ticket on adobe portal for the SVC test failure. Waiting for the approvals.

Thank you!

engcom-Charlie · 2022-11-04T06:42:03Z

@magento run Semantic Version Checker

magento-automated-testing · 2022-11-04T06:42:12Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2023-10-05T11:48:34Z

@engcom-Charlie any updates on this?

…abel-table

engcom-Charlie · 2024-03-25T10:55:17Z

@magento run all tests

engcom-Charlie · 2024-03-26T06:46:33Z

@ihor-sviziev we are waiting for the approvals, once that is done, will proceed with this PR and keep updated here.

magento-engcom-team added Component: Eav Release Line: 2.4 labels Nov 19, 2020

ihor-sviziev self-assigned this Nov 19, 2020

m2-community-project bot added the Progress: review label Nov 19, 2020

ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels Nov 19, 2020

ihor-sviziev added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 19, 2020

This was referenced Nov 19, 2020

Missing unique key on eav_attribute_option_value table #24718

Closed

MIssing unique key on eav_attribute_label table #24581

Closed

ihor-sviziev requested changes Nov 20, 2020

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Nov 20, 2020

ihor-sviziev reviewed Nov 20, 2020

View reviewed changes

app/code/Magento/Eav/etc/db_schema_whitelist.json Outdated Show resolved Hide resolved

m2-community-project bot added Progress: review and removed Progress: needs update labels Nov 20, 2020

engcom-Hotel self-assigned this Nov 20, 2020

ihor-sviziev added the Progress: needs update label Nov 20, 2020

m2-community-project bot added Progress: review and removed Progress: review Progress: needs update labels Nov 20, 2020

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Jun 6, 2022

Merge remote-tracking branch 'magento/2.4-develop' into missing-uniqu…

371280c

…e-key-on-eav_attribute_label-table

m2-community-project bot added Progress: pending approval and removed Progress: extended testing labels Jun 9, 2022

m2-community-project bot added Progress: pending review Progress: pending approval and removed Progress: pending approval labels Dec 14, 2022

ishakhsuvarov removed the Progress: pending review label Dec 14, 2022

Merge branch '2.4-develop' into missing-unique-key-on-eav_attribute_l…

1ba19f0

…abel-table

	<constraint xsi:type="unique" referenceId="EAV_ATTRIBUTE_LABEL_ATTRIBUTE_ID_STORE_ID_UNIQUE">
	<constraint xsi:type="unique" referenceId="EAV_ATTRIBUTE_LABEL_STORE_ID_ATTRIBUTE_ID">

Missing unique key on eav attribute label table #30981

Are you sure you want to change the base?

Missing unique key on eav attribute label table #30981

Uh oh!

Conversation

alex311982 commented Nov 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m2-assistant bot commented Nov 19, 2020

Uh oh!

alex311982 commented Nov 19, 2020

Uh oh!

alex311982 commented Nov 19, 2020

Uh oh!

ihor-sviziev commented Nov 19, 2020

Uh oh!

ihor-sviziev commented Nov 19, 2020

Uh oh!

alex311982 commented Nov 19, 2020

Uh oh!

ihor-sviziev commented Nov 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ihor-sviziev commented Nov 19, 2020

Uh oh!

alex311982 commented Nov 20, 2020

Uh oh!

ihor-sviziev Nov 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev Nov 20, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

engcom-Alfa commented Jun 6, 2022

Uh oh!

engcom-Charlie commented Jun 6, 2022

Uh oh!

magento-automated-testing bot commented Jun 6, 2022

Uh oh!

engcom-Charlie commented Jun 7, 2022

Uh oh!

magento-automated-testing bot commented Jun 7, 2022

Uh oh!

engcom-Charlie commented Jun 7, 2022

Uh oh!

magento-automated-testing bot commented Jun 7, 2022

Uh oh!

engcom-Charlie commented Jun 7, 2022

Uh oh!

magento-automated-testing bot commented Jun 7, 2022

Uh oh!

engcom-Charlie commented Jun 8, 2022

Uh oh!

magento-automated-testing bot commented Jun 8, 2022

Uh oh!

engcom-Charlie commented Jun 8, 2022

Uh oh!

magento-automated-testing bot commented Jun 8, 2022

Uh oh!

engcom-Charlie commented Jun 9, 2022

Uh oh!

engcom-Charlie commented Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Charlie commented Nov 4, 2022

Uh oh!

magento-automated-testing bot commented Nov 4, 2022

Uh oh!

ihor-sviziev commented Oct 5, 2023

Uh oh!

engcom-Charlie commented Mar 25, 2024

Uh oh!

engcom-Charlie commented Mar 26, 2024

Uh oh!

Uh oh!

alex311982 commented Nov 19, 2020 •

edited

Loading

ihor-sviziev commented Nov 19, 2020 •

edited

Loading

ihor-sviziev Nov 20, 2020 •

edited

Loading

engcom-Charlie commented Oct 21, 2022 •

edited

Loading