Developer Experience: Make getAdditionalConfig extensible

[lbajsarowicz]

Description (*)

For 2.5 branch

Currently when you need to add some extra data to Configurable Swatches, you need either:

• Inherit class and add your custom elements
• Plugin end decode the data before adding your

Example from Extension Vendor code:

To avoid such situations, I introduced the change that enables us to put our own data in Swatch config without unnecessary hassle.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Developer Experience: Make getAdditionalConfig extensible #30787: Developer Experience: Make getAdditionalConfig extensible

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[lbajsarowicz]

@magento run all tests

I don't remember if I can add a new public method to this specific class.

[lbajsarowicz]

@magento run all tests

[ihor-sviziev]

Looks good. Moving to "on hold" as it will wait for 2.5

[lbajsarowicz]

@magento run all tests

[ihor-sviziev]

Hi @lbajsarowicz,
Could you re-target your PR to 2.5-develop branch?

[ihor-sviziev]

@magento run Functional Tests CE

[engcom-Dash]

Hi @lbajsarowicz

Thanks for the collaboration & contribution!

✔️ QA Passed
Preconditions:

Install fresh Magento 2.4-develop
Steps to reproduce

• Create a plugin for app/code/Magento/ConfigurableProduct/Block/Product/View/Type/Configurable.php::getAdditionalConfig()
• Observe that the plugin code executes as expected.

Before: ✖️
Since we can't create a plugin for a private method, it will not be triggered anyway.

After: ✔️
Plugin is triggered.

Builds are failed. Hence moving it to Extended Testing.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Moving this PR to on hold since we are not picking up any PRs against the 2.5-develop branch right now. Once we pick it up, we will move it to the appropriate status.