Replaced all escape functions from $block object to $escaper object as a part of Magento coding standards.

[sanganinamrata]

Description (*)

Replaced all escape functions from $block object to $escaper object as a part of Magento coding standards.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @sanganinamrata. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[rogyar]

Hi @sanganinamrata. Thank you for the refactoring. I believe it would be a good idea if we perform the replacement everywhere in the system and not only in particular modules. What do you think about that?

[sanganinamrata]

Sure @rogyar,

Right now I've covered blank and luma themes, but I'll cover Magento individual modules as well in 2-3 days in different PR to make both theme and modules updates in different.

[hostep]

@rogyar:

Hi @sanganinamrata. Thank you for the refactoring. I believe it would be a good idea if we perform the replacement everywhere in the system and not only in particular modules. What do you think about that?

I really don't like this to happen in minor releases (2.4.2 for example), it generates a lot of changes in frontend code which causes a whole lot of unnecessary noise when reviewing such an update and extra work when you need to upgrade to a new minor release and adjust your own custom frontend theme to follow the new changes. I prefer if big changes in hundreds or thousands of different phtml files only happen in major releases (like 2.5.0).

(This comment is irrelevant if only 10 or 20 files will be affected, but please if this affects more then 20 files, consider to only ship this in Magento 2.5.0)

---

The same thing happened in Magento 2.3.3, where a bunch of new coding standards got applied to all the phtml files and it caused just soo much overhead and extra work, I really like to not have this happen in minor releases in the future any longer, because it makes upgrades to a minor release really expensive, we should try to make minor releases easy and effortless so people will actually want to invest the time to upgrade to them.

Thanks for considering this! :)

[ihor-sviziev]

Hi @rogyar,
I do agree with @hostep - in case if all the files will be refactored at once - please postpone these changes to 2.5.
Such consistency cleanups are very welcomed in case if someone will fix some issue in the file, but cleanup all together should be not in a patch versions.

[sanganinamrata]

Hi @ihor-sviziev,

So Should I update this PR affected changes to Magento core modules as requested by @rogyar at #30639 (review) ?

[ihor-sviziev]

I don't mind.
@rogyar what do you think?

[hostep]

It can probably be done, but just make sure the PR is not merged in 2.4-develop, we should wait until 2.5-develop becomes available before merging.

[sanganinamrata]

@hostep Sure, I would love to do that.

[rogyar]

@hostep @ihor-sviziev totally agree.
@sanganinamrata I would suggest closing this PR and creating a new one with all the replacements once we have 2.5-develop branch created.

Thanks

[hostep]

Hi @sanganinamrata: Since the 2.5-develop branch is now open, could you change the target branch of this PR to 2.5-develop (or open a new PR targeting that branch if that's easier) and then try to update all offending code in the Magento codebase?
Thanks!

[ihor-sviziev]

Hi @sanganinamrata,
We have a PR that already approved and targeted to 2.5-develop #31663 that doing the same.
I'm closing this PR.

[m2-assistant]

Hi @sanganinamrata, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.