Skip to content

Fix incorrect sort order link in customer navigation #30576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Oct 21, 2020

Description (*)

This PR is re-create of my previously #27340 continue fix for issue link in customer navigation incorrect sortOrder

Previously old PR has partial reverted because PR introduced new mix position links in some b2b-modules, ee-modules
Before the fix the core sort order link reversed and incorrect as expected
My update only cover modules included open source not all modules magento have. You can see image below for the rest of modules

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes SortOrder is reversed in layout XML #27162

Manual testing scenarios (*)

Login as customer
Case 1

  1. Go to My account
  2. See link in customer navigation show correctly
    Both case login and no login as customer

Case 2

  1. Go to homepage Click My account on top header for show dropdown links
  2. See links in dropdown should show in correct order

After change
Screenshot from 2020-10-21 22-41-42

CE modules
Before
Same as after change but sortOrder work not correct (reversed)
Screenshot from 2020-10-21 22-38-12

After change Same position but sortOrder work as expect
Screenshot from 2020-10-21 22-29-21

Questions or comments

CC: @ihor-sviziev How can i check order for other ecommerce modules not include in open source
Here is the list re-up from my previous PR
Expected results
nav-list

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 21, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Oct 21, 2020

Hi @mrtuvn,
If you don’t have access to we and b2b modules - fix should be provided on qa phase. I think it wasn’t added as such case just wasn’t tested at that time.

Could you add in description that this PR fixes #27162 (just reopened it)?

@ihor-sviziev ihor-sviziev self-assigned this Oct 21, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev ihor-sviziev added this to the 2.5 milestone Oct 21, 2020
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests CE

ihor-sviziev
ihor-sviziev previously approved these changes Oct 21, 2020
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Oct 21, 2020

Approved, but moving it to "on hold" as it should wait 2.5-develop branch.

Note for future: during QA please update sort orders for EE & B2B modules as author don't have access to them

@ghost ghost dismissed ihor-sviziev’s stale review October 21, 2020 11:15

Pull Request state was updated. Re-review required.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8362 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage labels Oct 21, 2020
@sidolov sidolov added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Oct 21, 2020
@sidolov sidolov added the Priority: P3 May be fixed according to the position in the backlog. label Oct 21, 2020
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Oct 28, 2020

@magento run Functional Tests CE

@mrtuvn mrtuvn changed the base branch from 2.4-develop to 2.5-develop January 8, 2021 08:32
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jan 8, 2021

re-target this to 2.5-develop

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests looks not related to changes from this PR.

Note for QA: as an author don't have access to EE & B2B repos - please make sure that all sort orders are updated accordingly there and not changing link position visually.

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests CE

2 similar comments
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 5, 2021

@magento run Functional Tests CE

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 10, 2021

@magento run Functional Tests CE

@m2-assistant
Copy link

m2-assistant bot commented Sep 12, 2021

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SortOrder is reversed in layout XML
5 participants