-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix incorrect sort order link in customer navigation #30576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect sort order link in customer navigation #30576
Conversation
Hi @mrtuvn. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento run Functional Tests CE |
Approved, but moving it to "on hold" as it should wait 2.5-develop branch. Note for future: during QA please update sort orders for EE & B2B modules as author don't have access to them |
Pull Request state was updated. Re-review required.
Hi @ihor-sviziev, thank you for the review.
|
@magento run Functional Tests CE |
re-target this to 2.5-develop |
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests CE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔ Approved.
Failing tests looks not related to changes from this PR.
Note for QA: as an author don't have access to EE & B2B repos - please make sure that all sort orders are updated accordingly there and not changing link position visually.
@magento run Functional Tests CE |
Hi @mrtuvn, thank you for your contribution! |
Description (*)
This PR is re-create of my previously #27340 continue fix for issue link in customer navigation incorrect sortOrder
Previously old PR has partial reverted because PR introduced new mix position links in some b2b-modules, ee-modules
Before the fix the core sort order link reversed and incorrect as expected
My update only cover modules included open source not all modules magento have. You can see image below for the rest of modules
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Login as customer
Case 1
Both case login and no login as customer
Case 2
After change

CE modules

Before
Same as after change but sortOrder work not correct (reversed)
After change Same position but sortOrder work as expect

Questions or comments
CC: @ihor-sviziev How can i check order for other ecommerce modules not include in open source

Here is the list re-up from my previous PR
Expected results
Contribution checklist (*)