Fix For Issue:Incorrect redirect navigate on the review edit page #29318 #30436

Yash-Bhayani · 2020-10-10T13:42:09Z

Description (*)

This Pull Request is for the resolution of the issue "Incorrect redirect navigate on the review edit page #29318"
The problem is when user redirects to the customer edit page from the product review edit page by clicking on the customer name at the product review page, the user couldn't redirect back to the product review page when it clicks on back button at customer edit page.I resolved this issue.

Changes in File:

app/code/Magento/Review/Block/Adminhtml/Edit/Form.php:135
-> in the link of the author(on click of which we redirected to the customer edit page) i added two additional parameter
(i) fromPath -> so that we can redirect back to the product review page by clicking on back button at customer edit page
(ii) review_id -> using which id parameter is prepared for back button at customer edit page
app/code/Magento/Customer/Block/Adminhtml/Edit/BackButton.php::getBackUrl

-> i used the passed parameter 'fromPath' and 'review_id' parameter to prepare back url for product review edit page
-> i wants the value of passed parameters so i added dependecy injection of \Magento\Customer\Block\Adminhtml\Edit\Form Block class.

in above file i used URL Encoder and URL Decoder so parameter(router/controller/action) passed as the value of 'fromPath' key interpreted currectly

Related Pull Requests

Fixed Issues (if relevant)

Fixes [Issue] Incorrect redirect navigate on the review edit page #29318

Manual testing scenarios (*)

Testing 1:

Go To Marketing -> User Content -> All Reviews
Click on Edit link of any Review
Click on Author Name
Click on "<- Back" Button
User is redirected to the "Edit Review" Page.

Testing 2:

Go To Customers ->Customers -> All Customers
Click on Edit link of Any Customer
Click on "<- Back" Button
User is redirected to the "Customer(Grid)" Page.

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-10-10T13:42:12Z

Hi @Yash-Bhayani. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Yash-Bhayani · 2020-10-10T13:43:55Z

#dmcdindia2020

Yash-Bhayani · 2020-10-10T13:46:45Z

@magento run all tests

rogyar · 2020-10-10T14:24:46Z

@magento give me test instance

magento-deployment-service · 2020-10-10T14:24:49Z

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2020-10-10T14:29:12Z

Hi @rogyar, here is your Magento Instance: https://ecf9d8d4bb1e3e9cec36217ff0d2f72f.instances.magento-community.engineering
Admin access: https://ecf9d8d4bb1e3e9cec36217ff0d2f72f.instances.magento-community.engineering/admin_77d5
Login: 8721b9cc
Password: 0a5349e4be08

rogyar · 2020-10-10T14:39:26Z

app/code/Magento/Customer/Block/Adminhtml/Edit/BackButton.php

+        if ($fromPath=$this->decoder->decode($this->form->getRequest()->getParam('fromPath'))) {
+            return $this->getUrl(
+                $fromPath,
+                ['id' => $this->form->getRequest()->getParam('review_id')]


I believe we need a universal solution for similar cases instead of fixing particular places. We see the same situation when we go to the customer information page from the order view page. So, we may have a couple more places in the admin panel where we have the same issue with the back button.

It would be great if we could find out how to solve this issue for all occurrences.

Hope it makes sense

Hello, @rogyar! I've done some investigation and I don't see the possibility to make a universal and reasonable solution for all "Back" buttons.

Hi @engcom-Foxtrot. I've been reflected on that for some time and you are right. It's not an easy task unless we have the same name for an entity identifier.

Anyway, thank you for checking!

rogyar · 2021-01-04T13:31:50Z

Hi @Yash-Bhayani. Could I kindly ask you to cover your changes with an MFTF test, please? According to the definition of done all new changes and fixes should be covered by auto-tests.

Thank you!

…w edit page.

engcom-Foxtrot · 2021-01-18T15:59:54Z

@magento run all tests

engcom-Foxtrot · 2021-01-18T16:00:44Z

@rogyar covered, please review.

engcom-Foxtrot · 2021-01-21T10:50:59Z

@magento run all tests

engcom-Foxtrot · 2021-01-21T22:10:50Z

@magento run all tests

engcom-Foxtrot · 2021-01-27T12:49:36Z

@magento run all tests

gabrieldagama

Hi @engcom-Foxtrot, can you have a look at my comment below? Thanks!

gabrieldagama · 2021-02-01T16:01:41Z

app/code/Magento/Customer/Block/Adminhtml/Edit/BackButton.php

@@ -32,6 +52,12 @@ public function getButtonData()
     */
    public function getBackUrl()
    {
+        if ($fromPath=$this->decoder->decode($this->form->getRequest()->getParam('fromPath'))) {


Instead of adding this parameter from the request, can't we use the RedirectInterface and the method getRefererUrl? This should return the URL that the request came from.

@gabrieldagama I don't think it's a good idea. This will cause redirect to any previously opened page and works as the 'back' button in the browser.

Yash-Bhayani added 2 commits October 10, 2020 17:05

Update BackButton.php

440a4cf

Update Form.php

206335f

ghost added the Progress: pending review label Oct 10, 2020

magento-engcom-team added Component: Customer Component: Review Release Line: 2.4 labels Oct 10, 2020

magento-engcom-team added the Event: dmcdindia2020 label Oct 10, 2020

Update Form.php

0a81ed8

rogyar requested changes Oct 10, 2020

View reviewed changes

ghost assigned rogyar Oct 10, 2020

ghost added Progress: needs update and removed Progress: pending review labels Oct 10, 2020

m2-community-project bot added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Oct 10, 2020

sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 10, 2020

engcom-Foxtrot self-assigned this Oct 27, 2020

ghost added Progress: review and removed Progress: needs update labels Oct 28, 2020

engcom-Foxtrot removed their assignment Oct 30, 2020

engcom-Foxtrot requested a review from rogyar December 28, 2020 11:56

engcom-Foxtrot self-assigned this Jan 15, 2021

m2-community-project bot added Progress: needs update and removed Progress: review labels Jan 18, 2021

Merge branch '2.4-develop-mainline' into 2.4-develop-Yash-Bhayani

c3f6365

magento#30436: Fix For Issue:Incorrect redirect navigate on the revie…

2ded1c1

…w edit page.

engcom-Foxtrot added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 18, 2021

m2-community-project bot added Progress: review Progress: pending review and removed Progress: needs update labels Jan 18, 2021

gabrieldagama suggested changes Feb 1, 2021

View reviewed changes

m2-community-project bot assigned gabrieldagama Feb 1, 2021

m2-community-project bot added Progress: needs update and removed Progress: pending review Progress: review labels Feb 1, 2021

m2-community-project bot added Progress: review and removed Progress: needs update labels Feb 12, 2021

m2-community-project bot added Progress: pending review and removed Progress: review labels Dec 7, 2022

Fix For Issue:Incorrect redirect navigate on the review edit page #29318 #30436

Are you sure you want to change the base?

Fix For Issue:Incorrect redirect navigate on the review edit page #29318 #30436

Uh oh!

Conversation

Yash-Bhayani commented Oct 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Oct 10, 2020

Uh oh!

Yash-Bhayani commented Oct 10, 2020

Uh oh!

Yash-Bhayani commented Oct 10, 2020

Uh oh!

rogyar commented Oct 10, 2020

Uh oh!

magento-deployment-service bot commented Oct 10, 2020

Uh oh!

magento-deployment-service bot commented Oct 10, 2020

Uh oh!

rogyar Oct 10, 2020

Choose a reason for hiding this comment

Uh oh!

engcom-Foxtrot Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rogyar Jan 4, 2021

Choose a reason for hiding this comment

Uh oh!

rogyar commented Jan 4, 2021

Uh oh!

engcom-Foxtrot commented Jan 18, 2021

Uh oh!

engcom-Foxtrot commented Jan 18, 2021

Uh oh!

engcom-Foxtrot commented Jan 21, 2021

Uh oh!

engcom-Foxtrot commented Jan 21, 2021

Uh oh!

engcom-Foxtrot commented Jan 27, 2021

Uh oh!

gabrieldagama left a comment

Choose a reason for hiding this comment

Uh oh!

gabrieldagama Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

engcom-Foxtrot Feb 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Yash-Bhayani commented Oct 10, 2020 •

edited

Loading

engcom-Foxtrot Oct 28, 2020 •

edited

Loading

engcom-Foxtrot Feb 12, 2021 •

edited

Loading