Skip to content

Assign user to role and roles list commands #28677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

Assign user to role and roles list commands #28677

wants to merge 1 commit into from

Conversation

Stepa4man
Copy link
Contributor

@Stepa4man Stepa4man commented Jun 11, 2020 •
edited by sidolov
Loading

Description (*)

Creates Admin-role management commands.

Manual testing scenarios (*)

  1. Run bin/magento admin:role:list
  2. Get some of the existing roles and save role ID
  3. Create new admin user from admin panel
  4. Run bin/magento admin:user:assign-role --username={USER_NAME} --role-id={SAVED_ROLE_ID}
  5. Check that user assigned to role

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Assign user to role and roles list commands #28803: Assign user to role and roles list commands

@m2-assistant
Copy link

m2-assistant bot commented Jun 11, 2020

Hi @Stepa4man. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@Stepa4man Stepa4man requested a review from orlangur June 11, 2020 00:05
@Stepa4man Stepa4man assigned orlangur and unassigned orlangur Jun 11, 2020
@Stepa4man Stepa4man changed the title Assign user to role command Assign user to role and roles list commands Jun 11, 2020
@Stepa4man
Copy link
Contributor Author

@magento run all tests

@Stepa4man
Copy link
Contributor Author

@magento run Static Tests

@Stepa4man
Copy link
Contributor Author

@magento run Functional Tests B2B

@ghost ghost assigned lbajsarowicz Jun 12, 2020
@ghost ghost assigned Stepa4man Jun 12, 2020
lbajsarowicz
lbajsarowicz reviewed Jun 12, 2020
View reviewed changes
@Stepa4man Stepa4man force-pushed the assign-user-to-role-command branch from 3d4d3a6 to 9101912 Compare June 14, 2020 18:57
@Stepa4man
Copy link
Contributor Author

@magento run all tests

@Stepa4man Stepa4man removed the request for review from orlangur June 18, 2020 14:34
@sidolov
Copy link
Contributor

sidolov commented Sep 10, 2020

@engcom-Hotel could you please take a look at failed integration tests? They constantly failed and caused by the changes from the PR

@engcom-Hotel engcom-Hotel self-assigned this Sep 30, 2020
@engcom-Foxtrot engcom-Foxtrot removed their assignment Oct 1, 2020
@engcom-Hotel
Copy link
Contributor

@magento run Integration Tests

@ghost ghost dismissed lbajsarowicz’s stale review October 6, 2020 14:26

Pull Request state was updated. Re-review required.

@andrewbess
Copy link
Contributor

@magento run Magento Health Index

lbajsarowicz
lbajsarowicz approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Code changes looks fine for me. Magento Healthcheck needs to be approved manually.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7710 has been created to process this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Delta engcom-Delta

@engcom-Hotel engcom-Hotel

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise Award: complex Component: Authorization Component: User Event: Global-Contribution-Day Partner: TechDivision partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: to approve QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Status: To Approve
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Assign user to role and roles list commands