Skip to content

Fixed customer back redirect navigate from edit product review #27983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ravi-chandra3197
Copy link
Contributor

@ravi-chandra3197 ravi-chandra3197 commented Apr 25, 2020

Description (*)

Fixed customer back redirect navigate from edit product review

Related Pull Requests

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: N/A

Manual testing scenarios (*)

  1. Admin -> Marketing -> All Reviews
  2. edit any review -> edit any customer
  3. click on back redirect

Expected result (*)

back redirect to edit review

Actual result (*)

back redirect to customer/index/index

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Incorrect redirect navigate on the review edit page #29318: Fixed customer back redirect navigate from edit product review

@m2-assistant
Copy link

m2-assistant bot commented Apr 25, 2020

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ravi-chandra3197. Thanks for collaboration. Can you please fix failed tests?

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-7516 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Kilo engcom-Kilo self-assigned this May 29, 2020
@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Kilo engcom-Kilo added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label May 29, 2020
@engcom-Kilo
Copy link
Contributor

Working on MFTF Test.

@engcom-Kilo
Copy link
Contributor

Added MFTF test

@engcom-Kilo
Copy link
Contributor

@magento run Functional Tests CE

@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Alfa
Copy link
Contributor

@magento create issue

@ghost ghost added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 7, 2020
@engcom-Kilo
Copy link
Contributor

Hi @ravi-chandra3197, I'm closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for your collaboration.

@m2-assistant
Copy link

m2-assistant bot commented Aug 11, 2020

Hi @ravi-chandra3197, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Component: Customer Component: Review Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: needs update Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Incorrect redirect navigate on the review edit page
5 participants