Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #21025 - Missing "Apply To" when editing Product attributes #27625

Open
wants to merge 12 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fix #21025 - Missing "Apply To" when editing Product attributes #27625

wants to merge 12 commits into from

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Apr 5, 2020 •
edited by ihor-sviziev
Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Missing "Apply To" when editing Product attributes #21025: Missing "Apply To" when editing Product attributes

Manual testing scenarios (*)

  1. Store -> Attributes -> Product
  2. Add New/Edit attributes
  3. Expand "Advanced Attribute Properties"
  4. There should be Apply To field editable for non-system attributes

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2020

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@orlangur orlangur self-assigned this Apr 9, 2020
@ghost ghost removed the Progress: pending review label Apr 9, 2020
@orlangur
Copy link
Contributor

orlangur commented Apr 9, 2020

Putting on hold until we decide in #21025 (comment) whether issue is valid or not.

@Bartlomiejsz
Copy link
Contributor Author

@orlangur based on #21025 (comment) - shouldn't this be unholded?

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 17, 2020
ihor-sviziev
ihor-sviziev requested changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bartlomiejsz,
Could you resolve conflicts?

@ghost ghost assigned ihor-sviziev Sep 22, 2020
@Bartlomiejsz
Merge branch '2.4-develop' into feature/fix_21025_missing_apply_to
727a077 
# Conflicts:
#	app/code/Magento/Catalog/Test/Unit/Block/Adminhtml/Product/Attribute/Edit/Tab/AdvancedTest.php
#	app/code/Magento/Catalog/Test/Unit/Controller/Adminhtml/Product/Attribute/SaveTest.php
@Bartlomiejsz
Copy link
Contributor Author

@magento run all tests

@Bartlomiejsz
Copy link
Contributor Author

@ihor-sviziev done

@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage labels Sep 22, 2020
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@Bartlomiejsz
Copy link
Contributor Author

hi @engcom-Lima, I merged 2.4-develop into this branch and resolved conflicts

@engcom-Delta engcom-Delta self-assigned this Dec 14, 2023
@engcom-Delta
Copy link
Contributor

@magento run all tests

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Delta
Copy link
Contributor

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

  1. Go to Store -> Attributes -> Product
  2. Add New/Edit attributes
  3. Expand "Advanced Attribute Properties"
  4. There should be Apply To field editable for non-system attributes

Before: ✖️ 

Screenshot 2023-12-14 at 5 28 23 PM Screenshot 2023-12-14 at 5 29 28 PM Screenshot 2023-12-14 at 5 29 58 PM

After: ✔️  

Screenshot 2023-12-14 at 6 08 38 PM Screenshot 2023-12-14 at 6 09 40 PM

Builds are failed. Hence, moving this PR to Extended Testing.

@engcom-Dash engcom-Dash self-assigned this Oct 3, 2024
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

1 similar comment
@engcom-Dash
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Oct 14, 2024 •
edited
Loading

The Functional EE, B2B and CE test failures are failing with one known issue. Hence moving to merge in progress.

Functional Tests EE
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/27625/d580bd673f8f740bd8e9e5bfe2c45965/Functional/allure-report-ee/index.html#categories/c6c6553a02a7680a5874353a75791825/359b9c61859dd996/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/27625/160356ced4ef782c8bb4a31a0f5cc21c/Functional/allure-report-ee/index.html#categories/c6c6553a02a7680a5874353a75791825/e9dcd9bad2451220/
image

Functional Tests CE
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/27625/80a069af9f85d1af3640a677546e5cc1/Functional/allure-report-ce/index.html#categories/c6c6553a02a7680a5874353a75791825/2922c2e73a4ac5b5/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/27625/8309e5ce86cbafd99819c7029857916e/Functional/allure-report-ce/index.html#categories/c6c6553a02a7680a5874353a75791825/f534516e20d9767c/
image

Functional Tests B2B
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/27625/c9c91466b7c74bec17f587592deda982/Functional/allure-report-b2b/index.html#categories/c6c6553a02a7680a5874353a75791825/ff3d97ceedca7504/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/27625/f8f1788aed4e23c5437b6629643154c0/Functional/allure-report-b2b/index.html#categories/c6c6553a02a7680a5874353a75791825/34d2ed95537966ec/
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev left review comments

@engcom-Alfa engcom-Alfa Awaiting requested review from engcom-Alfa

Assignees

@orlangur orlangur

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Delta engcom-Delta

@engcom-Dash engcom-Dash

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Catalog Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: needs update Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing "Apply To" when editing Product attributes
10 participants
@Bartlomiejsz @orlangur @magento-engcom-team @engcom-Foxtrot @ihor-sviziev @engcom-Alfa @engcom-Lima @engcom-Delta @engcom-Dash @sidolov