Skip to content

Set STATE_PROCESSING when order is in STATE_PENDING_PAYMENT #26935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sedonik
Copy link
Contributor

@sedonik sedonik commented Feb 19, 2020

Description (*)

Added one more case when order is checked of status. It validates is status "pending_payment" then set "processing" status to order.

  1. Order status pending payment not changing to processing after invoicing #26541: Order status pending payment not changing to processing after invoicing Order status pending payment not changing to processing after invoicing #26541

Manual testing scenarios (*)

  1. Cause I didn't reproduce moment when after Payment Getaway it lefts status "pending_payment'. I've only changed status in DB. Here is a screenshot where should be set (in item Order status pending payment not changing to processing after invoicing #26541).
  2. Create an invoice and submit.

@m2-assistant
Copy link

m2-assistant bot commented Feb 19, 2020

Hi @sedonik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-deployment-service
Copy link

Hi @m2-assistant[bot] Here is your new Magento Instance: https://undefined
Admin access: https://undefined/undefined
Login: undefined , Password: undefined

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Oct 19, 2020

Hi @sedonik,
The described issue was already fixed in #25876.

I'm closing this PR as there is no issue anymore.

Thank you so much for your contribution!

@m2-assistant
Copy link

m2-assistant bot commented Oct 19, 2020

Hi @sedonik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@tuyennn
Copy link
Member

tuyennn commented Aug 30, 2022

@ihor-sviziev I think @sedonik is trying to create an invoice in Admin-end while the order is till pending_payment and expect this should be processing after the invoice created. I don't think Magento supported this unless the order is treated as offline payment such as has state: new and status: pending for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants