[Fixed] - HTML Validation issue Replace Attribute with data-* attribute #26055

niravkrish · 2019-12-15T14:06:32Z

Other Related Pull Requests

Fix mftf inventory#2863

Description (*)

I have change attribute to data attributes in swatch-module and apply appropriate changes Javascript functions to achieve HTML validation as Mentioned In the Issue.

Fixed Issues (if relevant)

Layered navigation breaks HTML5 Validation #22363: Layered navigation breaks HTML5 Validation

Manual testing scenarios (*)

Manual Testing

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2019-12-15T14:06:34Z

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

ihor-sviziev · 2020-02-06T17:54:39Z

@magento run all tests

ihor-sviziev

Hi @niravkrish,
Your changes looks good to me, but tests should be updated accordingly.

Could you review test failures and fix them?

Also could you add the email that you've used in the commit to your GitHub account?

Pull Request state was updated. Re-review required.

ihor-sviziev · 2020-02-25T14:50:45Z

Hi @niravkrish,
Will you be able to update your PR?

ihor-sviziev

See my review above

… Fixed-22363 � Conflicts: � app/code/Magento/Swatches/view/frontend/templates/product/layered/renderer.phtml

engcom-Echo · 2020-02-27T11:39:47Z

I will try to fix it.

engcom-Echo · 2020-03-04T08:50:18Z

@magento run all tests

app/code/Magento/Catalog/Test/Mftf/Test/AdminBackorderAllowedAddProductToCartTest.xml

…ddProductToCartTest.xml Co-Authored-By: Ihor Sviziev <ihor-sviziev@users.noreply.github.com>

ihor-sviziev · 2020-03-04T12:43:59Z

@magento run all tests

magento-engcom-team · 2020-03-04T18:25:50Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7042 has been created to process this Pull Request

engcom-Bravo · 2020-03-05T08:29:28Z

✔️ QA Passed
No not allowed attribute error. See the attachment made Before PR on the left and After PR on the right

…ata-* attribute #26055

m2-assistant · 2020-03-26T18:48:03Z

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

fixed-html validation issue for some attribute

dd7674e

niravkrish requested review from akaplya and DrewML as code owners December 15, 2019 14:06

magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Dec 15, 2019

ihor-sviziev self-assigned this Feb 6, 2020

ihor-sviziev previously requested changes Feb 7, 2020

View reviewed changes

ghost added the Progress: needs update label Feb 7, 2020

ihor-sviziev added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix labels Feb 7, 2020

engcom-Echo self-assigned this Feb 24, 2020

ghost added Progress: review and removed Progress: needs update labels Feb 24, 2020

engcom-Echo removed their assignment Feb 24, 2020

ghost added Progress: pending review and removed Progress: review labels Feb 24, 2020

ghost added Progress: review and removed Progress: pending review labels Feb 25, 2020

ihor-sviziev requested changes Feb 26, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: review labels Feb 26, 2020

Merge branch '2.4-develop' of http://github.com/magento/magento2 into…

a81a09d

… Fixed-22363 � Conflicts: � app/code/Magento/Swatches/view/frontend/templates/product/layered/renderer.phtml

engcom-Echo self-assigned this Feb 27, 2020

Fix static

4f853e8

engcom-Echo force-pushed the Fixed-22363 branch from b154ba0 to d8d0ce4 Compare February 28, 2020 08:40

Fix unit and functional tests

1b3da7e

engcom-Echo force-pushed the Fixed-22363 branch from e8d1797 to 1b3da7e Compare March 3, 2020 09:57

This was referenced Mar 3, 2020

Fix MFTF tests magento/inventory#2860

Closed

Fix mftf magento/inventory#2863

Merged

engcom-Echo requested a review from ihor-sviziev March 4, 2020 10:23

ihor-sviziev reviewed Mar 4, 2020

View reviewed changes

app/code/Magento/Catalog/Test/Mftf/Test/AdminBackorderAllowedAddProductToCartTest.xml Outdated Show resolved Hide resolved

engcom-Echo and others added 2 commits March 4, 2020 13:06

Update app/code/Magento/Catalog/Test/Mftf/Test/AdminBackorderAllowedA…

7be7c49

…ddProductToCartTest.xml Co-Authored-By: Ihor Sviziev <ihor-sviziev@users.noreply.github.com>

Update AdminBackorderAllowedAddProductToCartTest.xml

c92cd52

ihor-sviziev approved these changes Mar 4, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: review labels Mar 4, 2020

magento-engcom-team added Release Line: 2.4 Area: Frontend Component: Catalog Component: Swatches labels Mar 4, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Mar 5, 2020

engcom-Bravo self-assigned this Mar 5, 2020

ghost added Progress: extended testing Progress: accept and removed Progress: testing in progress Progress: extended testing labels Mar 5, 2020

magento-engcom-team pushed a commit that referenced this pull request Mar 26, 2020

ENGCOM-7042: [Fixed] - HTML Validation issue Replace Attribute with d…

f8a7358

…ata-* attribute #26055

magento-engcom-team merged commit b00619f into magento:2.4-develop Mar 26, 2020

sdzhepa mentioned this pull request May 9, 2022

tyutyu sdzhepa/magento2#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Fixed] - HTML Validation issue Replace Attribute with data-* attribute #26055

[Fixed] - HTML Validation issue Replace Attribute with data-* attribute #26055

Uh oh!

niravkrish commented Dec 15, 2019 •

edited by lenaorobei

Loading

Uh oh!

m2-assistant bot commented Dec 15, 2019

Uh oh!

ihor-sviziev commented Feb 6, 2020

Uh oh!

ihor-sviziev left a comment •

edited

Loading

Uh oh!

ihor-sviziev commented Feb 25, 2020

Uh oh!

ihor-sviziev left a comment

Uh oh!

engcom-Echo commented Feb 27, 2020

Uh oh!

engcom-Echo commented Mar 4, 2020

Uh oh!

Uh oh!

ihor-sviziev commented Mar 4, 2020

Uh oh!

magento-engcom-team commented Mar 4, 2020

Uh oh!

engcom-Bravo commented Mar 5, 2020

Uh oh!

m2-assistant bot commented Mar 26, 2020

Uh oh!

Uh oh!

[Fixed] - HTML Validation issue Replace Attribute with data-* attribute #26055

[Fixed] - HTML Validation issue Replace Attribute with data-* attribute #26055

Uh oh!

Conversation

niravkrish commented Dec 15, 2019 • edited by lenaorobei Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other Related Pull Requests

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Dec 15, 2019

Uh oh!

ihor-sviziev commented Feb 6, 2020

Uh oh!

ihor-sviziev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev commented Feb 25, 2020

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Echo commented Feb 27, 2020

Uh oh!

engcom-Echo commented Mar 4, 2020

Uh oh!

Uh oh!

ihor-sviziev commented Mar 4, 2020

Uh oh!

magento-engcom-team commented Mar 4, 2020

Uh oh!

engcom-Bravo commented Mar 5, 2020

Uh oh!

m2-assistant bot commented Mar 26, 2020

Uh oh!

Uh oh!

niravkrish commented Dec 15, 2019 •

edited by lenaorobei

Loading

ihor-sviziev left a comment •

edited

Loading