-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix document elements check to prevent WYSIWYG error on IE #25693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix document elements check to prevent WYSIWYG error on IE #25693
Conversation
When creating a document using DomParser's parseFromString method from an empty string, IE 11 returns a document which both head and body elements are null, which caused the errors. Fixes magento#13209
Hi @krzksz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento give me test instance |
Hi @krzksz. Thank you for your request. I'm working on Magento instance for you |
Hi @krzksz, here is your new Magento instance. |
Hi @lbajsarowicz, thank you for the review.
|
Hello @lbajsarowicz. Would You please add an appropriate label to this PR. Thank You. |
Label added. |
Hello @krzksz. Thank You for Your contribution. Please cover Your PR with the appropriate Auto-Tests in order for us to be able to process it further. Thank You. |
Alright, I'm up for the challenge! 😄 |
So I tried to prepare tests for this scenario but there are 2 issues with covering it:
|
@engcom-Bravo I believe this can be picked up for QA and merge now. |
✔️ QA Passed |
Hi @krzksz, thank you for your contribution! |
Description (*)
When creating a document using
DomParser
'sparseFromString
method from an empty string, IE 11 returns a document which bothhead
andbody
elements arenull
, which caused the errors.Fixes #13209
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)