Skip to content

Fix document elements check to prevent WYSIWYG error on IE #25693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

krzksz
Copy link
Contributor

@krzksz krzksz commented Nov 21, 2019

Description (*)

When creating a document using DomParser's parseFromString method from an empty string, IE 11 returns a document which both head and body elements are null, which caused the errors.

Fixes #13209

Fixed Issues (if relevant)

  1. Wysiwyg editor fails on IE11 #13209: Wysiwyg editor fails on IE11

Manual testing scenarios (*)

  1. Open Magento admin panel on Internet Explorer 11.
  2. Go to any WYSIWYG editor field, e.g. CMS page content editor.
  3. Start typing.
  4. No error popup is displayed.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

When creating a document using DomParser's parseFromString method from an empty string, IE 11
returns a document which both head and body elements are null, which caused the errors.

Fixes magento#13209
@krzksz krzksz requested a review from DrewML as a code owner November 21, 2019 23:10
@m2-assistant
Copy link

m2-assistant bot commented Nov 21, 2019

Hi @krzksz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@krzksz
Copy link
Contributor Author

krzksz commented Nov 21, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @krzksz. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, here is your new Magento instance.
Admin access: https://pr-25693.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6310 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Bravo
Copy link
Contributor

Hello @lbajsarowicz. Would You please add an appropriate label to this PR. Thank You.

@lbajsarowicz lbajsarowicz added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Nov 22, 2019
@lbajsarowicz
Copy link
Contributor

Hello @lbajsarowicz. Would You please add an appropriate label to this PR. Thank You.

Label added.

@engcom-Bravo
Copy link
Contributor

Hello @krzksz. Thank You for Your contribution. Please cover Your PR with the appropriate Auto-Tests in order for us to be able to process it further. Thank You.

@krzksz
Copy link
Contributor Author

krzksz commented Nov 22, 2019

Alright, I'm up for the challenge! 😄

@krzksz
Copy link
Contributor Author

krzksz commented Nov 26, 2019

So I tried to prepare tests for this scenario but there are 2 issues with covering it:

  1. MFTF documentation states that A Selenium web driver cannot enter data to fields with WYSIWYG. so I am not able to test it.
  2. Even if I where then I believe tests are not executed on IE, where error occurs.

@lbajsarowicz lbajsarowicz added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Nov 26, 2019
@krzksz
Copy link
Contributor Author

krzksz commented Nov 26, 2019

@engcom-Bravo I believe this can be picked up for QA and merge now.

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 27, 2019
@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Dec 2, 2019
@magento-engcom-team magento-engcom-team merged commit ddb9acb into magento:2.3-develop Dec 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 3, 2019

Hi @krzksz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Partner: creativestyle partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wysiwyg editor fails on IE11
6 participants