Skip to content

Resolve Wrong message in confirmation popup when delete customer group issue25661 #25662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edenduong
Copy link
Contributor

@edenduong edenduong commented Nov 20, 2019

Description (*)

Resolve Wrong message in confirmation popup when delete customer group issue25661

Fixed Issues (if relevant)

  1. Wrong message in confirmation popup when delete customer group #25661: Wrong message in confirmation popup when delete customer group

Manual testing scenarios (*)

  1. Go to backend
  2. Customer -> Customer Groups
  3. Create customer group with name test-test
  4. Back to grid, choose that customer, select and click delete
    See:

image

Expected result

  1. Correct message with test-test

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@edenduong edenduong requested a review from paliarush as a code owner November 20, 2019 07:33
@m2-assistant
Copy link

m2-assistant bot commented Nov 20, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned pmclain Nov 20, 2019
@pmclain pmclain added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Nov 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @pmclain, thank you for the review.
ENGCOM-6304 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

@m2-assistant
Copy link

m2-assistant bot commented Nov 24, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 24, 2019
@hostep hostep mentioned this pull request Nov 9, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants