Skip to content

Fixed regex for validate action in admin menu #25612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 3, 2019
Merged

Fixed regex for validate action in admin menu #25612

merged 4 commits into from
Dec 3, 2019

Conversation

diegocpires
Copy link
Contributor

@diegocpires diegocpires commented Nov 14, 2019 •
edited
Loading

Description (*)

Validator for action menu doesn't accept "-".

Fixed Issues (if relevant)

  1. Bug when create a new admin route with hyphen #25635: Bug when create a new admin route wirh hyphen

Manual testing scenarios (*)

  1. Create a new route for Admin with "-"
  2. Create a new menu for Admin with "-" in action.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 14, 2019

Hi @diegocpires. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@diegocpires diegocpires self-assigned this Nov 14, 2019
@ghost ghost unassigned diegocpires Nov 14, 2019
@ghost
Copy link

ghost commented Nov 14, 2019

@diegocpires unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@diegocpires
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @diegocpires. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @diegocpires, here is your new Magento instance.
Admin access: https://pr-25612.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rodrigowebjump rodrigowebjump self-assigned this Nov 15, 2019
@GDauer
Copy link
Contributor

GDauer commented Nov 15, 2019

@magento give me 2.3 instance

rodrigowebjump
rodrigowebjump approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@rodrigowebjump rodrigowebjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @diegocpires

Thanks for your contribution

@rodrigowebjump rodrigowebjump added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix labels Nov 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-6347 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@diegocpires thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa engcom-Alfa self-assigned this Nov 28, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 28, 2019
@VladimirZaets VladimirZaets mentioned this pull request Dec 3, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Dec 3, 2019
@VladimirZaets
ENGCOM-6347: Fixed regex for validate action in admin menu #25612
73e4c6f
@magento-engcom-team magento-engcom-team merged commit 4fd4e60 into magento:2.3-develop Dec 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 3, 2019

Hi @diegocpires, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigowebjump rodrigowebjump rodrigowebjump approved these changes

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@rodrigowebjump rodrigowebjump

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Backend Partner: Webjump partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.5
Development

Successfully merging this pull request may close these issues.
6 participants
@diegocpires @magento-engcom-team @GDauer @engcom-Alfa @rodrigowebjump @engcom-Foxtrot